8313795: Fix for JDK-8313564 breaks ppc and s390x builds#15165
8313795: Fix for JDK-8313564 breaks ppc and s390x builds#15165RealCLanger wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
|
Ping @coleenp 😄 |
|
@RealCLanger The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thanks Thomas. Will integrate when GHA is through and confirms that the patch works. Luckily, the cross-build should be repaired by now. |
|
GHA looks good. Integrating to unbreak builds. /integrate |
|
Going to push as commit 6d18529.
Your commit was automatically rebased without conflicts. |
|
@RealCLanger Pushed as commit 6d18529. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The fix for JDK-8313564 breaks the ppc and s390x builds. This should repair it.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15165/head:pull/15165$ git checkout pull/15165Update a local copy of the PR:
$ git checkout pull/15165$ git pull https://git.openjdk.org/jdk.git pull/15165/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15165View PR using the GUI difftool:
$ git pr show -t 15165Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15165.diff
Webrev
Link to Webrev Comment