Skip to content

8313791: Fix just zPage.inline.hpp and xPage.inline.hpp#15166

Closed
coleenp wants to merge 1 commit intoopenjdk:masterfrom
coleenp:zgc-small-conversion
Closed

8313791: Fix just zPage.inline.hpp and xPage.inline.hpp#15166
coleenp wants to merge 1 commit intoopenjdk:masterfrom
coleenp:zgc-small-conversion

Conversation

@coleenp
Copy link
Contributor

@coleenp coleenp commented Aug 4, 2023

Please review this trivial change to fix -Wconversion warnings for these two files, which are included almost everywhere so generate lots of warnings.
Tested with tier1 on Oracle supported platforms linux/macos/windows x86/aarch64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313791: Fix just zPage.inline.hpp and xPage.inline.hpp (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15166/head:pull/15166
$ git checkout pull/15166

Update a local copy of the PR:
$ git checkout pull/15166
$ git pull https://git.openjdk.org/jdk.git pull/15166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15166

View PR using the GUI difftool:
$ git pr show -t 15166

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15166.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2023

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 4, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313791: Fix just zPage.inline.hpp and xPage.inline.hpp

Reviewed-by: stefank, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • dc01604: 8305636: Expand and clean up predicate classes and move them into separate files
  • a38fdaf: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key.
  • c1f4595: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem
  • 90d795a: 8313141: Missing check for os_thread type in os_windows.cpp
  • 6d18529: 8313795: Fix for JDK-8313564 breaks ppc and s390x builds
  • ad6e9e7: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry
  • b463c6d: 8311517: Add performance information to ArrayList javadoc
  • b2add96: 8159527: Collections mutator methods should all be marked as optional operations
  • 873d117: 8312623: SA add NestHost and NestMembers attributes when dumping class
  • 017e0c7: 8310388: Shenandoah: Auxiliary bitmap is not madvised for THP

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 4, 2023
@coleenp
Copy link
Contributor Author

coleenp commented Aug 7, 2023

Thanks Stefan and Thomas.
/integrate

@openjdk
Copy link

openjdk bot commented Aug 7, 2023

Going to push as commit 0bb6af3.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 4b192a8: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly
  • 0b4387e: 8310643: Misformatted copyright messages in FFM
  • 538f955: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • 226cdc6: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
  • dc01604: 8305636: Expand and clean up predicate classes and move them into separate files
  • a38fdaf: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key.
  • c1f4595: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem
  • 90d795a: 8313141: Missing check for os_thread type in os_windows.cpp
  • 6d18529: 8313795: Fix for JDK-8313564 breaks ppc and s390x builds
  • ad6e9e7: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry
  • ... and 4 more: https://git.openjdk.org/jdk/compare/f66cd5008d155e52a20a351ecd10469286517bf4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 7, 2023
@openjdk openjdk bot closed this Aug 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 7, 2023
@coleenp coleenp deleted the zgc-small-conversion branch August 7, 2023 12:06
@openjdk
Copy link

openjdk bot commented Aug 7, 2023

@coleenp Pushed as commit 0bb6af3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants