8313791: Fix just zPage.inline.hpp and xPage.inline.hpp#15166
8313791: Fix just zPage.inline.hpp and xPage.inline.hpp#15166coleenp wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
|
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Thanks Stefan and Thomas. |
|
Going to push as commit 0bb6af3.
Your commit was automatically rebased without conflicts. |
Please review this trivial change to fix -Wconversion warnings for these two files, which are included almost everywhere so generate lots of warnings.
Tested with tier1 on Oracle supported platforms linux/macos/windows x86/aarch64.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15166/head:pull/15166$ git checkout pull/15166Update a local copy of the PR:
$ git checkout pull/15166$ git pull https://git.openjdk.org/jdk.git pull/15166/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15166View PR using the GUI difftool:
$ git pr show -t 15166Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15166.diff
Webrev
Link to Webrev Comment