-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8312597: Convert TraceTypeProfile to UL #15167
Conversation
👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into |
@benty-amzn The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
85a4573
to
2a7bdce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me!
Other reviewers might want to take a look.
/reviewers 2
@benty-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 78 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
/integrate |
@benty-amzn |
/sponsor |
Going to push as commit 0074b48.
Your commit was automatically rebased without conflicts. |
@phohensee @benty-amzn Pushed as commit 0074b48. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The new test files are causing a build failure in our CI due to an issue with the copyright notice and/or GPL header. Trying to ascertain exactly what it doesn't like ... |
IANAL but IIUC it is perfectly fine to have an Amazon only copyright notice, but the rest of the GPL header must be what Oracle has defined i.e. Oracle designates the CPE not Amazon, and the Oracle contact information must be present. |
D'oh. I completely missed the header text was changed. Yes, it should be the way you made it in b7dee21. Thanks! |
This PR adds the output from
-XX:+TraceTypeProfile
to thejit
andinlining
tags in unified logging. It also adds minimal tests for-XX:+TraceTypeProfile
and-Xlog:jit*=debug
.Change passes tier1 tests.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15167/head:pull/15167
$ git checkout pull/15167
Update a local copy of the PR:
$ git checkout pull/15167
$ git pull https://git.openjdk.org/jdk.git pull/15167/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15167
View PR using the GUI difftool:
$ git pr show -t 15167
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15167.diff
Webrev
Link to Webrev Comment