Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312597: Convert TraceTypeProfile to UL #15167

Closed
wants to merge 1 commit into from

Conversation

benty-amzn
Copy link

@benty-amzn benty-amzn commented Aug 4, 2023

This PR adds the output from -XX:+TraceTypeProfile to the jit and inlining tags in unified logging. It also adds minimal tests for -XX:+TraceTypeProfile and -Xlog:jit*=debug.

Change passes tier1 tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8312597: Convert TraceTypeProfile to UL (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15167/head:pull/15167
$ git checkout pull/15167

Update a local copy of the PR:
$ git checkout pull/15167
$ git pull https://git.openjdk.org/jdk.git pull/15167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15167

View PR using the GUI difftool:
$ git pr show -t 15167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15167.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2023

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@benty-amzn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 4, 2023
@benty-amzn benty-amzn force-pushed the 8312597 branch 2 times, most recently from 85a4573 to 2a7bdce Compare August 4, 2023 21:52
@benty-amzn benty-amzn marked this pull request as ready for review August 7, 2023 20:17
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 7, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 7, 2023

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me!

Other reviewers might want to take a look.

/reviewers 2

@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312597: Convert TraceTypeProfile to UL

Reviewed-by: shade, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

  • f142470: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out
  • 595fdd3: 8314059: Remove PKCS7.verify()
  • 49b2984: 8313854: Some tests in serviceability area fail on localized Windows platform
  • c132176: 8114830: (fs) Files.copy fails due to interference from something else changing the file system
  • e56d3bc: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • 4b2703a: 8313678: SymbolTable can leak Symbols during cleanup
  • f41c267: 8314045: ArithmeticException in GaloisCounterMode
  • 911d1db: 8314078: HotSpotConstantPool.lookupField() asserts due to field changes in ConstantPool.cpp
  • 6574dd7: 8314025: Remove JUnit-based test in java/lang/invoke from problem list
  • 207bd00: 8313756: [BACKOUT] 8308682: Enhance AES performance
  • ... and 68 more: https://git.openjdk.org/jdk/compare/87b08b6e0192d88025c2275c7dd2c4bdecda58e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 8, 2023
@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@shipilev
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 8, 2023
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 9, 2023
@benty-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 14, 2023
@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@benty-amzn
Your change (at version 994f6d0) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

Going to push as commit 0074b48.
Since your change was applied there have been 79 commits pushed to the master branch:

  • 1f1c5c6: 8314241: Add test/jdk/sun/security/pkcs/pkcs7/SignerOrder.java to ProblemList
  • f142470: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out
  • 595fdd3: 8314059: Remove PKCS7.verify()
  • 49b2984: 8313854: Some tests in serviceability area fail on localized Windows platform
  • c132176: 8114830: (fs) Files.copy fails due to interference from something else changing the file system
  • e56d3bc: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • 4b2703a: 8313678: SymbolTable can leak Symbols during cleanup
  • f41c267: 8314045: ArithmeticException in GaloisCounterMode
  • 911d1db: 8314078: HotSpotConstantPool.lookupField() asserts due to field changes in ConstantPool.cpp
  • 6574dd7: 8314025: Remove JUnit-based test in java/lang/invoke from problem list
  • ... and 69 more: https://git.openjdk.org/jdk/compare/87b08b6e0192d88025c2275c7dd2c4bdecda58e8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 14, 2023
@openjdk openjdk bot closed this Aug 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 14, 2023
@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@phohensee @benty-amzn Pushed as commit 0074b48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora
Copy link
Member

The new test files are causing a build failure in our CI due to an issue with the copyright notice and/or GPL header. Trying to ascertain exactly what it doesn't like ...

@dholmes-ora
Copy link
Member

IANAL but IIUC it is perfectly fine to have an Amazon only copyright notice, but the rest of the GPL header must be what Oracle has defined i.e. Oracle designates the CPE not Amazon, and the Oracle contact information must be present.

@shipilev
Copy link
Member

IANAL but IIUC it is perfectly fine to have an Amazon only copyright notice, but the rest of the GPL header must be what Oracle has defined i.e. Oracle designates the CPE not Amazon, and the Oracle contact information must be present.

D'oh. I completely missed the header text was changed. Yes, it should be the way you made it in b7dee21. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants