8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM

[plummercj]

Normally we want the test args passed to the SA debuggee. In fact for proper SA test coverage, it is more important for the test args to be passed to the debuggee than to be passed to the test or the the SA tool that the test launches. For a couple of jhsdb tests that launch jshell as the debuggee, this wasn't happening, and jshell was always launched with no extra args.

Fixing this was very simple. Dealing with the unexpected fallout wasn't. I filed a number of bugs that turned up (or where otherwise exposed) once I fixed this CR. The main ones were:

JDK-8313798 [aarch64] sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java sometimes times out on aarch64
JDK-8313655 sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java frequently fails with SerialGC

For the first one I'm problem listing the test for now, but have a fix and will get it out for review shortly. For the second one I'm just having the test avoid the issue by not allowing jshell to be launched with SerialGC.

Note also that this change caused some failures with ZGC due to an already filed CR.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM (Bug - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15168/head:pull/15168
$ git checkout pull/15168

Update a local copy of the PR:
$ git checkout pull/15168
$ git pull https://git.openjdk.org/jdk.git pull/15168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15168

View PR using the GUI difftool:
$ git pr show -t 15168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15168.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following labels will be automatically applied to this pull request:

• core-libs
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fbf4ceff)

[plummercj]

/label remove core-libs

[openjdk]

@plummercj
The core-libs label was successfully removed.

[sspitsyn]

Looks okay to me.
Thanks,
Serguei

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM

Reviewed-by: sspitsyn, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 90d795a: 8313141: Missing check for os_thread type in os_windows.cpp
• 6d18529: 8313795: Fix for JDK-8313564 breaks ppc and s390x builds

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Thank you Leonid and Serguei!

/integrate

[openjdk]

Going to push as commit 87b08b6.
Since your change was applied there have been 16 commits pushed to the master branch:

• 83edffa: 8309663: test fails "assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe"
• 1da82a3: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
• 9c6eb67: 8313167: Update to use jtreg 7.3
• 380418f: 8295058: test/langtools/tools/javac 116 test classes uses com.sun.tools.classfile library
• 4726960: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
• bbbfa21: 8313880: Incorrect copyright header in jdk/java/foreign/TestFree.java after JDK-8310643
• 0bb6af3: 8313791: Fix just zPage.inline.hpp and xPage.inline.hpp
• 4b192a8: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly
• 0b4387e: 8310643: Misformatted copyright messages in FFM
• 538f955: 8313701: GHA: RISC-V should use the official repository for bootstrap
• ... and 6 more: https://git.openjdk.org/jdk/compare/ad6e9e75bff24e74c888d9b96c3f698ae0f54127...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 87b08b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.