Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257242: [macOS] Java app crashes while switching input methods #1517

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Nov 30, 2020

It seems the patch for https://bugs.openjdk.java.net/browse/JDK-8248532 causes a crash, as it attempts to call a method selector on a class for an instance method (- keyboardInputSourceChanged). It was not observed in 10.14 but seen in 10.15 or later.
It resulted in crash as we are passing [AWTView class] as an instance to the notification observer but notification function keyboardInputSourceChanged is not a member function.
Modified the code to make that function a class-level function so that it does not crash.
mucommander.app, JDK-8214578 testcase worked with this change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) (2/9 failed) (1/9 failed)

Failed test tasks

Issue

  • JDK-8257242: [macOS] Java app crashes while switching input methods

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1517/head:pull/1517
$ git checkout pull/1517

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 30, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2020

@prsadhuk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Nov 30, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 30, 2020

Webrevs

@mrserb
Copy link
Member

@mrserb mrserb commented Nov 30, 2020

Do you have a chance to reproduce this crash?

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Nov 30, 2020

No, but Alex did as he has Catalina and my patch solved his crash.

@mrserb
mrserb approved these changes Nov 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2020

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257242: [macOS] Java app crashes while switching input methods

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 411 new commits pushed to the master branch:

  • a3e1980: 8256541: Sort out what version of awk is used in the build system
  • e3abe51: 8257418: C2: Rename barrier data member in MemNode and LoadStoreNode
  • c071960: 8257083: Security infra test failures caused by JDK-8202343
  • 4db05e9: 8254042: gtest/GTestWrapper.java failed os.test_random
  • 962f7a3: 8257162: Initialize ThreadLocalAllocBuffer members
  • 337d7bc: 8257165: C2: Improve box elimination for vector masks and shuffles
  • 4e55d0f: 8257057: C2: Improve safepoint processing during vector scalarization pass
  • e77aed6: 8256754: Deoptimization::revoke_for_object_deoptimization: stack processing start call is redundant
  • 738efea: 8248564: JFR: Remote Recording Stream
  • 9bcd269: 8257221: C2: RegMask::is_bound_set split set handling broken since JDK-8221404
  • ... and 401 more: https://git.openjdk.java.net/jdk/compare/f389a718a8eb67bfa8e47406ac0e47385567eba6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 30, 2020
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Dec 1, 2020

/integrate

@openjdk openjdk bot closed this Dec 1, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 1, 2020
@prsadhuk prsadhuk deleted the prsadhuk:JDK-8257242 branch Dec 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2020

@prsadhuk Since your change was applied there have been 423 commits pushed to the master branch:

  • 7d89852: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files
  • 4356469: 8230501: Class data support for hidden classes
  • 11dad14: 8257445: (zipfs) Add DataProvider to TestLocOffsetFromZip64EF.java
  • 29f86e0: 8256536: Newer AMD 19h (EPYC) Processor family defaults
  • 7f58a8e: 8213719: Both sect163r2 and sect163k1 are default curves for field size 163
  • ae5b526: 8257448: Clean duplicated non-null check in the SunJSSE provider implementation
  • 41dbc13: 8180352: Add Stream.toList() method
  • 8969069: 8256995: [vector] Improve broadcast operations
  • 6eb25d7: 8254082: AbstractStringBuilder.insert(int dstOffset, CharSequence s, int start, int end) is missing fast-path for String
  • 4c86e46: 8256810: Incremental rebuild broken on Macosx
  • ... and 413 more: https://git.openjdk.java.net/jdk/compare/f389a718a8eb67bfa8e47406ac0e47385567eba6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 822ee47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants