8313891: JFR: Incorrect exception message for RecordedObject::getInt

[egahlin]

Could I have a review of PR that fixes an incorrect exception message.

Testing: test/jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313891: JFR: Incorrect exception message for RecordedObject::getInt (Bug - P4)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15181/head:pull/15181
$ git checkout pull/15181

Update a local copy of the PR:
$ git checkout pull/15181
$ git pull https://git.openjdk.org/jdk.git pull/15181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15181

View PR using the GUI difftool:
$ git pr show -t 15181

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15181.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a920e8a5)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313891: JFR: Incorrect exception message for RecordedObject::getInt

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 509f80b: 8313889: Fix -Wconversion warnings in foreign benchmarks
• 5c3041c: 8313435: Clean up unused default methods code
• 8752d49: 8313785: Fix -Wconversion warnings in prims code
• 41bdcde: 8313875: Use literals instead of static fields in java.util.Math: twoToTheDoubleScaleUp, twoToTheDoubleScaleDown
• 091e65e: 8313552: Fix -Wconversion warnings in JFR code
• 7e20952: 8140326: G1: Consider putting regions where evacuation failed into next collection set
• 28fd7a1: 8311179: Generational ZGC: gc/z/TestSmallHeap.java failed with OutOfMemoryError
• a1115a7: 8312204: unexpected else with statement causes compiler crash
• 87a6acb: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md
• 87b08b6: 8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM
• ... and 4 more: https://git.openjdk.org/jdk/compare/4726960fcdc9489fb8f9c7e1a100828f1347c30c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 213d3c4.
Since your change was applied there have been 27 commits pushed to the master branch:

• 0e2c72d: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer
• 52ec4bc: 8303056: Improve support for Unicode characters and digits in JavaDoc search
• 9cf12bb: 8313922: Remove unused WorkerPolicy::_debug_perturbation
• 6e3cc13: 8312467: relax the builddir check in make/autoconf/basic.m4
• 77e5739: 8310118: Resource files should be moved to appropriate directories
• 96304f3: 8313691: use close after failing os::fdopen in vmError and ciEnv
• 3fb4805: 8307462: [REDO] VmObjectAlloc is not generated by intrinsics methods which allocate objects
• 0a42c44: 8313954: Add gc logging to vmTestbase/vm/gc/containers/Combination05
• 735b16a: 8313752: InstanceKlassFlags::print_on doesn't print the flag names
• d3b578f: 8313345: SuperWord fails due to CMove without matching Bool pack
• ... and 17 more: https://git.openjdk.org/jdk/compare/4726960fcdc9489fb8f9c7e1a100828f1347c30c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 213d3c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.