JDK-8315318: Typo in comment on sun.nio.ch.Net.unblock4

[shiker1996]

Modify the comment on the unblock4() method, because the original comment will cause people to misunderstand.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315318: Typo in comment on sun.nio.ch.Net.unblock4 (Bug - P5)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)
• Vyom Tewari (@vyommani - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15186/head:pull/15186
$ git checkout pull/15186

Update a local copy of the PR:
$ git checkout pull/15186
$ git pull https://git.openjdk.org/jdk.git pull/15186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15186

View PR using the GUI difftool:
$ git pr show -t 15186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15186.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @shiker1996, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user shiker1996" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@shiker1996 The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[shiker1996]

/signed shiker1996

[MBaesken]

Looks okay to me thanks for fixing the comment.
You need a JBS issue for this however, and the number needs to show up in the subject ('Corrected wrong comment ...').
Should I open a JBS issue for you?

[openjdk]

@shiker1996 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315318: Typo in comment on sun.nio.ch.Net.unblock4

Reviewed-by: mbaesken, vtewari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 266 new commits pushed to the master branch:

• dd64a4a: 8315241: (fs) Move toRealPath tests in java/nio/file/Path/Misc.java to separate JUnit 5 test
• 8e4cda0: 8314834: serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
• 1ea6463: 8314835: gtest wrappers should be marked as flagless
• 93e82c0: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags
• 7daae1f: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
• 6701eba: 8315117: Update Zlib Data Compression Library to Version 1.3
• e29f0c2: 8297777: Convert jdk.jlink StringSharingPlugin to use Class File API
• bf63945: 8298992: runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)"
• cb3f968: 8314651: G1: Fix -Wconversion warnings in static fields of HeapRegion
• 876a725: 8315206: RISC-V: hwprobe query is_set return wrong value
• ... and 256 more: https://git.openjdk.org/jdk/compare/87b08b6e0192d88025c2275c7dd2c4bdecda58e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken, @vyommani) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shiker1996]

/integrate

[openjdk]

@shiker1996
Your change (at version eb3dcbe) is now ready to be sponsored by a Committer.

[mlbridge]

Webrevs

• 00: Full (eb3dcbeb)

[vyommani]

Looks OK.

[AlanBateman]

/sponsor

[openjdk]

Going to push as commit 39f1813.
Since your change was applied there have been 274 commits pushed to the master branch:

• 47aa6f3: 8315219: G1: Improve allocator pathological case where it keeps doing direct allocations instead of retiring a PLAB
• 218829e: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
• 3c8a667: 8314611: Provide more explicative error message parsing Currencies
• df5e6e5: 8315248: AssertionError in Name.compareTo
• 3eac890: 8315061: Make LockingMode a product flag
• 8419a53: 8315072: Remove unneeded AdaptivePaddedAverage::operator new
• c90cd2c: 8286789: Test forceEarlyReturn002.java timed out
• 89d18ea: 8312018: Improve reservation of class space and CDS
• dd64a4a: 8315241: (fs) Move toRealPath tests in java/nio/file/Path/Misc.java to separate JUnit 5 test
• 8e4cda0: 8314834: serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
• ... and 264 more: https://git.openjdk.org/jdk/compare/87b08b6e0192d88025c2275c7dd2c4bdecda58e8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman @shiker1996 Pushed as commit 39f1813.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.