8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16

[JimLaskey]

The last fragment of a string template does not get it's coder added to the mix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16 (Bug - P2)

Reviewers

• Claes Redestad (@cl4es - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15195/head:pull/15195
$ git checkout pull/15195

Update a local copy of the PR:
$ git checkout pull/15195
$ git pull https://git.openjdk.org/jdk.git pull/15195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15195

View PR using the GUI difftool:
$ git pr show -t 15195

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15195.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JimLaskey The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3dba5187)
• 00: Full (ae6bc58c)

[cl4es]

LGTM. This also adds an implicit null check on the last fragment.

[openjdk]

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16

Reviewed-by: redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[cl4es]

This works. Thanks!

[JimLaskey]

/integrate

[openjdk]

Going to push as commit 6864441.

[openjdk]

@JimLaskey Pushed as commit 6864441.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[JimLaskey]

/backport jdk21

[openjdk]

@JimLaskey the backport was successfully created on the branch JimLaskey-backport-68644411 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 68644411 from the openjdk/jdk repository.

The commit being backported was authored by Jim Laskey on 8 Aug 2023 and was reviewed by Claes Redestad.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git JimLaskey-backport-68644411:JimLaskey-backport-68644411
$ git checkout JimLaskey-backport-68644411
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git JimLaskey-backport-68644411