8313654: Test WaitNotifySuspendedVThreadTest.java timed out

[lmesnik]

Test might times out if it suspend thread before it starts breakpoint event handler.
The fix is to replace sleep with better synchronization and suspend virtual thread only when it runs native code.

Also, the completed monitor is acquired earlier to avoid racing when completing test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313654: Test WaitNotifySuspendedVThreadTest.java timed out (Bug - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to 53bb6235

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15196/head:pull/15196
$ git checkout pull/15196

Update a local copy of the PR:
$ git checkout pull/15196
$ git pull https://git.openjdk.org/jdk.git pull/15196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15196

View PR using the GUI difftool:
$ git pr show -t 15196

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15196.diff

Webrev

Link to Webrev Comment

[lmesnik]

JFYI Test's summary was just copied from another test and completely unrelated.

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (303a4f60)
• 00: Full (53bb6235)

[sspitsyn]

Looks good.
Thank you for taking care about it.
Thanks,
Serguei

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313654: Test WaitNotifySuspendedVThreadTest.java timed out

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

• c307391: 8307184: Incorrect/inconsistent specification and implementation for Elements.getDocComment
• 593ba2f: 8313693: Introduce an internal utility for the Damerau–Levenshtein distance calculation
• 360f65d: 8314022: Problem-list tests failing with jtreg 7.3
• 0eb0997: 8288936: Wrong lock ordering writing G1HeapRegionTypeChange JFR event
• 19ae62a: 8311170: Simplify and modernize equals and hashCode in security area
• e9f751a: 8311247: Some cpp files are compiled with -std:c11 flag
• 213d3c4: 8313891: JFR: Incorrect exception message for RecordedObject::getInt
• 0e2c72d: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer
• 52ec4bc: 8303056: Improve support for Unicode characters and digits in JavaDoc search
• 9cf12bb: 8313922: Remove unused WorkerPolicy::_debug_perturbation
• ... and 34 more: https://git.openjdk.org/jdk/compare/90d795abf10bf8b8b53079c1afd19fee7b4cb6cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lmesnik]

/integrate

[openjdk]

Going to push as commit 9b53251.
Since your change was applied there have been 57 commits pushed to the master branch:

• e7c83ea: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
• 23fe2ec: 8313616: support loading library members on AIX in os::dll_load
• f47767f: 8313882: Fix -Wconversion warnings in runtime code
• 0cb9ab0: 8313239: InetAddress.getCanonicalHostName may return ip address if reverse lookup fails
• 028b3ae: 8313874: JNI NewWeakGlobalRef throws exception for null arg
• 83adaf5: 8313421: [JVMCI] avoid locking class loader in CompilerToVM.lookupType
• 35b60f9: 8298095: Refine implSpec for SegmentAllocator
• 6dba202: 8313670: Simplify shared lib name handling code in some tests
• 8f28809: 8299790: os::print_hex_dump is racy
• e080a0b: 8311508: ZGC: RAII use of IntelJccErratumAlignment
• ... and 47 more: https://git.openjdk.org/jdk/compare/90d795abf10bf8b8b53079c1afd19fee7b4cb6cf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 9b53251.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.