8313899: JVMCI exception Translation can fail in TranslatedException.<clinit> #15198

dougxc · 2023-08-08T20:52:29Z

In a test that stresses metaspace (such as vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java) that also uses -Xcomp -XX:-TieredCompilation, we've seen a failure in TranslatedException.<clinit> due to exhausted metaspace:

java.lang.OutOfMemoryError: Metaspace
        at jdk.internal.vm.TranslatedException.encodeThrowable(java.base@21/TranslatedException.java:176)
        at jdk.internal.vm.TranslatedException.<clinit>(java.base@21/TranslatedException.java:61)
        at jdk.internal.vm.VMSupport.encodeThrowable(java.base@21/VMSupport.java:171)

This PR pushes a fix such that this exception is properly handled in the VM (i.e. causing a compilation bailout) instead of leading to a VM crash.

The PR includes 2 bits of debug code guarded by system properties that enable the handling to be tested in libgraal. The test itself is not included as libgraal is not part of OpenJDK.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8313899: JVMCI exception Translation can fail in TranslatedException.<clinit> (Bug - P3)

Reviewers

Tom Rodriguez (@tkrodriguez - Reviewer) ⚠️ Review applies to 529258a8
Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15198/head:pull/15198
$ git checkout pull/15198

Update a local copy of the PR:
$ git checkout pull/15198
$ git pull https://git.openjdk.org/jdk.git pull/15198/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15198

View PR using the GUI difftool:
$ git pr show -t 15198

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15198.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-08-08T20:53:50Z

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-08-08T20:55:09Z

@dougxc The following labels will be automatically applied to this pull request:

core-libs
graal
hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

tkrodriguez

Looks good.

openjdk · 2023-08-09T09:31:38Z

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313899: JVMCI exception Translation can fail in TranslatedException.<clinit>

Reviewed-by: never, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

23fe2ec: 8313616: support loading library members on AIX in os::dll_load
f47767f: 8313882: Fix -Wconversion warnings in runtime code
0cb9ab0: 8313239: InetAddress.getCanonicalHostName may return ip address if reverse lookup fails
028b3ae: 8313874: JNI NewWeakGlobalRef throws exception for null arg
83adaf5: 8313421: [JVMCI] avoid locking class loader in CompilerToVM.lookupType
35b60f9: 8298095: Refine implSpec for SegmentAllocator
6dba202: 8313670: Simplify shared lib name handling code in some tests
8f28809: 8299790: os::print_hex_dump is racy
e080a0b: 8311508: ZGC: RAII use of IntelJccErratumAlignment
242a2e6: 8308843: Generational ZGC: Remove gc/z/TestHighUsage.java
... and 20 more: https://git.openjdk.org/jdk/compare/515add88ed6c290ee90f3d6f522a22971e37a62c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

mlbridge · 2023-08-09T09:56:28Z

Webrevs

01: Full - Incremental (f160cb80)
00: Full (529258a8)

dougxc · 2023-08-10T11:57:26Z

src/hotspot/share/jvmci/jvmciEnv.cpp

                            vmSupport,
                            vmSymbols::encodeThrowable_name(),
                            vmSymbols::encodeThrowable_signature(), &jargs, THREAD);
+    if (handle_pending_exception(THREAD, buffer, buffer_size)) {


This is the actual bug fix: handle any exception occurring in the Java upcall.

TobiHartmann

Looks good to me too.

TobiHartmann

Still looks good to me.

dougxc · 2023-08-10T18:52:15Z

Thanks for the reviews.

/integrate

openjdk · 2023-08-10T18:53:06Z

Going to push as commit 6f5c903.
Since your change was applied there have been 36 commits pushed to the master branch:

d97de82: 8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action!
79be8d9: 8312259: StatusResponseManager unused code clean up
1875b28: 8314061: [JVMCI] DeoptimizeALot stress logic breaks deferred barriers
bd1b942: 8313905: Checked_cast assert in CDS compare_by_loader
9b53251: 8313654: Test WaitNotifySuspendedVThreadTest.java timed out
e7c83ea: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
23fe2ec: 8313616: support loading library members on AIX in os::dll_load
f47767f: 8313882: Fix -Wconversion warnings in runtime code
0cb9ab0: 8313239: InetAddress.getCanonicalHostName may return ip address if reverse lookup fails
028b3ae: 8313874: JNI NewWeakGlobalRef throws exception for null arg
... and 26 more: https://git.openjdk.org/jdk/compare/515add88ed6c290ee90f3d6f522a22971e37a62c...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-08-10T18:53:15Z

@dougxc Pushed as commit 6f5c903.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

handle exception in TranslatedException.<clinit> (JDK-8313899)

529258a

openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Aug 8, 2023

tkrodriguez approved these changes Aug 9, 2023

View reviewed changes

dougxc marked this pull request as ready for review August 9, 2023 09:30

openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2023

dougxc commented Aug 10, 2023

View reviewed changes

TobiHartmann approved these changes Aug 10, 2023

View reviewed changes

dougxc added 2 commits August 10, 2023 15:31

omit test-only code in product build

788dd0e

guard test-only code with ASSERT instead of !PRODUCT

f160cb8

TobiHartmann approved these changes Aug 10, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Aug 10, 2023

openjdk bot closed this Aug 10, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8313899: JVMCI exception Translation can fail in TranslatedException.<clinit> #15198

8313899: JVMCI exception Translation can fail in TranslatedException.<clinit> #15198

Uh oh!

dougxc commented Aug 8, 2023 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Aug 8, 2023

Uh oh!

openjdk bot commented Aug 8, 2023

Uh oh!

tkrodriguez left a comment

Uh oh!

openjdk bot commented Aug 9, 2023 •

edited

Loading

Uh oh!

mlbridge bot commented Aug 9, 2023 •

edited

Loading

Uh oh!

dougxc Aug 10, 2023

Uh oh!

TobiHartmann left a comment

Uh oh!

TobiHartmann left a comment

Uh oh!

dougxc commented Aug 10, 2023

Uh oh!

openjdk bot commented Aug 10, 2023

Uh oh!

openjdk bot commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

8313899: JVMCI exception Translation can fail in TranslatedException.<clinit> #15198

8313899: JVMCI exception Translation can fail in TranslatedException.<clinit> #15198

Uh oh!

Conversation

dougxc commented Aug 8, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Aug 8, 2023

Uh oh!

openjdk bot commented Aug 8, 2023

Uh oh!

tkrodriguez left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

dougxc Aug 10, 2023

Choose a reason for hiding this comment

Uh oh!

TobiHartmann left a comment

Choose a reason for hiding this comment

Uh oh!

TobiHartmann left a comment

Choose a reason for hiding this comment

Uh oh!

dougxc commented Aug 10, 2023

Uh oh!

openjdk bot commented Aug 10, 2023

Uh oh!

openjdk bot commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

dougxc commented Aug 8, 2023 •

edited by openjdk bot

Loading

openjdk bot commented Aug 9, 2023 •

edited

Loading

mlbridge bot commented Aug 9, 2023 •

edited

Loading