Skip to content

Conversation

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Aug 9, 2023

Removed empty module so CTW doesn't fail.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15201/head:pull/15201
$ git checkout pull/15201

Update a local copy of the PR:
$ git checkout pull/15201
$ git pull https://git.openjdk.org/jdk.git pull/15201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15201

View PR using the GUI difftool:
$ git pr show -t 15201

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15201.diff

Webrev

Link to Webrev Comment

@lmesnik
Copy link
Member Author

lmesnik commented Aug 9, 2023

/cc hotspot-compiler

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2023

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-compiler hotspot-compiler-dev@openjdk.org labels Aug 9, 2023
@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@lmesnik
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 9, 2023

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • c822183: 8313768: Reduce interaction with volatile field in j.u.l.StreamHandler
  • cd16158: 8314075: Update JCov version for JDK 22
  • c307391: 8307184: Incorrect/inconsistent specification and implementation for Elements.getDocComment
  • 593ba2f: 8313693: Introduce an internal utility for the Damerau–Levenshtein distance calculation
  • 360f65d: 8314022: Problem-list tests failing with jtreg 7.3
  • 0eb0997: 8288936: Wrong lock ordering writing G1HeapRegionTypeChange JFR event
  • 19ae62a: 8311170: Simplify and modernize equals and hashCode in security area
  • e9f751a: 8311247: Some cpp files are compiled with -std:c11 flag
  • 213d3c4: 8313891: JFR: Incorrect exception message for RecordedObject::getInt
  • 0e2c72d: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer
  • ... and 10 more: https://git.openjdk.org/jdk/compare/515add88ed6c290ee90f3d6f522a22971e37a62c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 9, 2023
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lmesnik
Copy link
Member Author

lmesnik commented Aug 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 10, 2023

Going to push as commit e7c83ea.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 23fe2ec: 8313616: support loading library members on AIX in os::dll_load
  • f47767f: 8313882: Fix -Wconversion warnings in runtime code
  • 0cb9ab0: 8313239: InetAddress.getCanonicalHostName may return ip address if reverse lookup fails
  • 028b3ae: 8313874: JNI NewWeakGlobalRef throws exception for null arg
  • 83adaf5: 8313421: [JVMCI] avoid locking class loader in CompilerToVM.lookupType
  • 35b60f9: 8298095: Refine implSpec for SegmentAllocator
  • 6dba202: 8313670: Simplify shared lib name handling code in some tests
  • 8f28809: 8299790: os::print_hex_dump is racy
  • e080a0b: 8311508: ZGC: RAII use of IntelJccErratumAlignment
  • 242a2e6: 8308843: Generational ZGC: Remove gc/z/TestHighUsage.java
  • ... and 20 more: https://git.openjdk.org/jdk/compare/515add88ed6c290ee90f3d6f522a22971e37a62c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 10, 2023
@openjdk openjdk bot closed this Aug 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 10, 2023
@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@lmesnik Pushed as commit e7c83ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants