-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8314025: Remove JUnit-based test in java/lang/invoke from problem list #15206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8314025: Remove JUnit-based test in java/lang/invoke from problem list #15206
Conversation
👋 Welcome back cstein! A progress list of the required criteria for merging this PR into |
@sormuras To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add core-libs |
@jaikiran |
Hello Christian, I think this PR should also be linked against the problem listed JBS issue https://bugs.openjdk.org/browse/JDK-8312482 so that when this is integrated that issue gets resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bug management is a bit awkward here. I would suggest closing JDK-8312482 as a dup of the codetools issue if allowed, else close it as "external" and link to the codetools issue.
Thanks
@sormuras This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 6574dd7.
Your commit was automatically rebased without conflicts. |
Please review this change to remove Unit-based tests in
java/lang/invoke
fromjdk
's problem list. The underlying race condition in jtreg was fixed in release 7.3; which is now the default version used in JDK mainline development.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15206/head:pull/15206
$ git checkout pull/15206
Update a local copy of the PR:
$ git checkout pull/15206
$ git pull https://git.openjdk.org/jdk.git pull/15206/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15206
View PR using the GUI difftool:
$ git pr show -t 15206
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15206.diff
Webrev
Link to Webrev Comment