Skip to content

8314025: Remove JUnit-based test in java/lang/invoke from problem list #15206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Aug 9, 2023

Please review this change to remove Unit-based tests in java/lang/invoke from jdk's problem list. The underlying race condition in jtreg was fixed in release 7.3; which is now the default version used in JDK mainline development.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314025: Remove JUnit-based test in java/lang/invoke from problem list (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15206/head:pull/15206
$ git checkout pull/15206

Update a local copy of the PR:
$ git checkout pull/15206
$ git pull https://git.openjdk.org/jdk.git pull/15206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15206

View PR using the GUI difftool:
$ git pr show -t 15206

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15206.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2023

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 9, 2023
@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@sormuras To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@jaikiran
Copy link
Member

/label add core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 10, 2023
@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@jaikiran
The core-libs label was successfully added.

@jaikiran
Copy link
Member

jaikiran commented Aug 10, 2023

Hello Christian, I think this PR should also be linked against the problem listed JBS issue https://bugs.openjdk.org/browse/JDK-8312482 so that when this is integrated that issue gets resolved.

@mlbridge
Copy link

mlbridge bot commented Aug 10, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug management is a bit awkward here. I would suggest closing JDK-8312482 as a dup of the codetools issue if allowed, else close it as "external" and link to the codetools issue.

Thanks

@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314025: Remove JUnit-based test in java/lang/invoke from problem list

Reviewed-by: dholmes, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 23fe2ec: 8313616: support loading library members on AIX in os::dll_load
  • f47767f: 8313882: Fix -Wconversion warnings in runtime code
  • 0cb9ab0: 8313239: InetAddress.getCanonicalHostName may return ip address if reverse lookup fails
  • 028b3ae: 8313874: JNI NewWeakGlobalRef throws exception for null arg
  • 83adaf5: 8313421: [JVMCI] avoid locking class loader in CompilerToVM.lookupType
  • 35b60f9: 8298095: Refine implSpec for SegmentAllocator
  • 6dba202: 8313670: Simplify shared lib name handling code in some tests
  • 8f28809: 8299790: os::print_hex_dump is racy
  • e080a0b: 8311508: ZGC: RAII use of IntelJccErratumAlignment
  • 242a2e6: 8308843: Generational ZGC: Remove gc/z/TestHighUsage.java
  • ... and 10 more: https://git.openjdk.org/jdk/compare/52ec4bcb1bab15dbf0a9b2488d33a23cdc1cb0e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 10, 2023
@sormuras
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

Going to push as commit 6574dd7.
Since your change was applied there have been 48 commits pushed to the master branch:

  • 207bd00: 8313756: [BACKOUT] 8308682: Enhance AES performance
  • 823f5b9: 8308850: Change JVM options with small ranges that get -Wconversion warnings to 32 bits
  • 5bfb82e: 8314119: G1: Fix -Wconversion warnings in G1CardSetInlinePtr::card_pos_for
  • 06aa3c5: 8314118: Update JMH devkit to 1.37
  • 4164693: 8313372: [JVMCI] Export vmIntrinsics::is_intrinsic_available results to JVMCI compilers.
  • 049b55f: 8314019: Add gc logging to jdk/jfr/event/gc/detailed/TestZAllocationStallEvent.java
  • a39ed10: 8314116: C2: assert(false) failed: malformed control flow after JDK-8305636
  • 1de5bf1: 8314106: C2: assert(is_valid()) failed: must be valid after JDK-8305636
  • 5c91622: 8314117: RISC-V: Incorrect VMReg encoding in RISCV64Frame.java
  • 6bbcef5: 8313948: Remove unnecessary static fields defaultUpper/defaultLower in sun.net.PortConfig
  • ... and 38 more: https://git.openjdk.org/jdk/compare/52ec4bcb1bab15dbf0a9b2488d33a23cdc1cb0e1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 14, 2023
@openjdk openjdk bot closed this Aug 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 14, 2023
@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@sormuras Pushed as commit 6574dd7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants