-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8314056 Remove runtime platform check from frem/drem #15210
Conversation
👋 Welcome back sgibbons! A progress list of the required criteria for merging this PR into |
@asgibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
__ stmxcsr(Address(rsp, 0)); | ||
__ movl(rax, Address(rsp, 0)); | ||
__ movl(rcx, rax); | ||
__ orl(rcx, 0x7f80); | ||
__ movl(Address(rsp, 0x04), rcx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to do stmxcsr, we could define mxcsr_rz on similar lines as mxcsr_std as part of StubGenerator::create_control_words() and use those in fmod.
__ movl(rcx, rax); | ||
__ orl(rcx, 0x7f80); | ||
__ movl(Address(rsp, 0x04), rcx); | ||
|
||
__ andl(rax, 0x6000); | ||
__ cmpl(rax, 0x2000); | ||
__ jcc(Assembler::equal, L_10c1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the jcc and jmp could be generated as short branches where feasible.
Also the stub and the loop entries could be aligned to 16 bytes for better perf.
The changes look good to me now. Could you please also get the performance of DremFrem jmh micro with/without your PR for both UseAVX=2 and UseAVX=3? |
Results of DremFrem: Before these changes:
=============================================
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me. Thanks for considering all the review comments.
@asgibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 283 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sviswa7, @jatin-bhateja) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/label hotspot-compiler |
@sviswa7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me, you may also include the results of following benchmark.
./test/micro/org/openjdk/bench/vm/compiler/pea/Blender.java
__ jcc(Assembler::aboveEqual, L_117f); | ||
__ jmp(L_11af); | ||
__ align32(); | ||
__ jccb(Assembler::aboveEqual, L_117f); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bounded label jump, Assembler::jcc should automatically optimize it with short jump encoding, but its not a blocker.
/integrate |
@asgibbons |
@jddarcy FYI. If you'd like to review, it would be appreciated. Thanks. |
/sponsor |
Going to push as commit ce2a7ea.
Your commit was automatically rebased without conflicts. |
@jatin-bhateja @asgibbons Pushed as commit ce2a7ea. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Remove platform check and move code to stubGenerator. This fix increases performance by ~4.5%.
UPDATE: Subsequent commits increase performance gain to ~2x for AVX2, with no significant change to AVX512.
Tested tier1.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15210/head:pull/15210
$ git checkout pull/15210
Update a local copy of the PR:
$ git checkout pull/15210
$ git pull https://git.openjdk.org/jdk.git pull/15210/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15210
View PR using the GUI difftool:
$ git pr show -t 15210
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15210.diff
Webrev
Link to Webrev Comment