8314061: [JVMCI] DeoptimizeALot stress logic breaks deferred barriers

[tkrodriguez]

JVMCIRuntime::new_array_common includes a little bit of stress logic that changes how it returns when DeoptimizeALot is set. This can cause it to bypass the call to SharedRuntime::on_slowpath_allocation_exit(current) which is where the deferred card mark logic lives. This can lead to random crashes of various kinds.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314061: [JVMCI] DeoptimizeALot stress logic breaks deferred barriers (Bug - P3)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Doug Simon (@dougxc - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15218/head:pull/15218
$ git checkout pull/15218

Update a local copy of the PR:
$ git checkout pull/15218
$ git pull https://git.openjdk.org/jdk.git pull/15218/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15218

View PR using the GUI difftool:
$ git pr show -t 15218

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15218.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back never! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tkrodriguez The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f07b6070)

[TobiHartmann]

Looks good to me.

[openjdk]

@tkrodriguez This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314061: [JVMCI] DeoptimizeALot stress logic breaks deferred barriers

Reviewed-by: thartmann, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 35b60f9: 8298095: Refine implSpec for SegmentAllocator
• 6dba202: 8313670: Simplify shared lib name handling code in some tests
• 8f28809: 8299790: os::print_hex_dump is racy
• e080a0b: 8311508: ZGC: RAII use of IntelJccErratumAlignment
• 242a2e6: 8308843: Generational ZGC: Remove gc/z/TestHighUsage.java
• c822183: 8313768: Reduce interaction with volatile field in j.u.l.StreamHandler
• cd16158: 8314075: Update JCov version for JDK 22
• c307391: 8307184: Incorrect/inconsistent specification and implementation for Elements.getDocComment
• 593ba2f: 8313693: Introduce an internal utility for the Damerau–Levenshtein distance calculation
• 360f65d: 8314022: Problem-list tests failing with jtreg 7.3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tkrodriguez]

Thanks!

/integrate

[openjdk]

Going to push as commit 1875b28.
Since your change was applied there have been 18 commits pushed to the master branch:

• bd1b942: 8313905: Checked_cast assert in CDS compare_by_loader
• 9b53251: 8313654: Test WaitNotifySuspendedVThreadTest.java timed out
• e7c83ea: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
• 23fe2ec: 8313616: support loading library members on AIX in os::dll_load
• f47767f: 8313882: Fix -Wconversion warnings in runtime code
• 0cb9ab0: 8313239: InetAddress.getCanonicalHostName may return ip address if reverse lookup fails
• 028b3ae: 8313874: JNI NewWeakGlobalRef throws exception for null arg
• 83adaf5: 8313421: [JVMCI] avoid locking class loader in CompilerToVM.lookupType
• 35b60f9: 8298095: Refine implSpec for SegmentAllocator
• 6dba202: 8313670: Simplify shared lib name handling code in some tests
• ... and 8 more: https://git.openjdk.org/jdk/compare/0eb0997ae4f81314b764241e69dae5c698dbb6c6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tkrodriguez Pushed as commit 1875b28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.