8255264: Support for identifying the full range of IPv4 localhost addresses on Windows #1523

macarte · 2020-11-30T18:09:57Z

Modified Windows specific loopback macros to support full range of loopback addresses, commit message includes unit test data as there's no gtest's for java libraries (only hotspot compiler)

This is an expansion on the original fix for 8250521: Configure initial RTO to use minimal retry for loopback connections on Windows

IPV4 loopback addresses are defined as 127.0.0.0/8 the CIDR translates to a range of 127.0.0.0 to
127.255.255.255 inclusive.

The previous macro implementation only identified 127.0.0.1 and ::1 as loopback addresses, this is corrected in this change

Note that as IPV6 is defined as ::1/128 only ::1 is a valid loopback address

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8255264: Support for identifying the full range of IPv4 localhost addresses on Windows

Reviewers

Alan Bateman (@AlanBateman - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1523/head:pull/1523
$ git checkout pull/1523

…resses on Windows

bridgekeeper · 2020-11-30T18:10:19Z

Hi @macarte, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user macarte" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

macarte · 2020-11-30T18:10:36Z

/covered

openjdk · 2020-11-30T18:11:24Z

@macarte The following label will be automatically applied to this pull request:

net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

bridgekeeper · 2020-11-30T18:11:30Z

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

mlbridge · 2020-12-01T16:45:06Z

Webrevs

00: Full (deeae3d)

mlbridge · 2020-12-08T17:48:16Z

Mailing list message from Mat Carter on net-dev:

Have an RFR needing a sponsor and review - this is related to Nikola's prior work on JDK-8250521: Configure initial RTO to use minimal retry for loopback connections on Windows

Thanks in advance
Mat Carter

Sent from Outlook

From: net-dev <net-dev-retn at openjdk.java.net> on behalf of Mat Carter <github.com+54955201+macarte at openjdk.java.net>
Sent: Tuesday, December 1, 2020 8:45 AM
To: net-dev at openjdk.java.net <net-dev at openjdk.java.net>
Subject: RFR: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows
?
Modified Windows specific loopback macros to support full range of loopback addresses, commit message includes unit test data as there's no gtest's for java libraries (only hotspot compiler)

This is an expansion on the original fix for 8250521: Configure initial RTO to use minimal retry for loopback connections on Windows

IPV4 loopback addresses are defined as 127.0.0.0/8 the CIDR translates to a range of 127.0.0.0 to
127.255.255.255 inclusive.

The previous macro implementation only identified 127.0.0.1 and ::1 as loopback addresses, this is corrected in this change

Note that as IPV6 is defined as ::1/128 only ::1 is a valid loopback address

-------------

Commit messages:
?- 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows

Changes: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openjdk.java.net%2Fjdk%2Fpull%2F1523%2Ffiles&data=04%7C01%7Cmatthew.carter%40microsoft.com%7C064ac0511f8d456a8f0108d89618859e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637424379353506711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=E6vGW2cv%2F8xbbwQ7LXAHnNJlCMz%2FDYuE2mf7Cb4XL%2F8%3D&reserved=0
?Webrev: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwebrevs.openjdk.java.net%2F%3Frepo%3Djdk%26pr%3D1523%26range%3D00&data=04%7C01%7Cmatthew.carter%40microsoft.com%7C064ac0511f8d456a8f0108d89618859e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637424379353506711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3zrfHSmoebfb6frkKY2hiPvFmE2fwfWD0JTSKP0GySU%3D&reserved=0
? Issue: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8255264&data=04%7C01%7Cmatthew.carter%40microsoft.com%7C064ac0511f8d456a8f0108d89618859e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637424379353506711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=nARpDuRflecA48G4BuWoDTXLE1eq9oM%2BExoEnnaPfEM%3D&reserved=0
? Stats: 17 lines in 1 file changed: 6 ins; 0 del; 11 mod
? Patch: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openjdk.java.net%2Fjdk%2Fpull%2F1523.diff&data=04%7C01%7Cmatthew.carter%40microsoft.com%7C064ac0511f8d456a8f0108d89618859e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637424379353506711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Sij9ITYHDondJDDG2SGfxMCuu84rDAncUWPiKQP3YdY%3D&reserved=0
? Fetch: git fetch https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openjdk.java.net%2Fjdk&data=04%7C01%7Cmatthew.carter%40microsoft.com%7C064ac0511f8d456a8f0108d89618859e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637424379353506711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=EL%2BrIjy0g%2FQtORAa2bSNQQvJJ%2Fv9vB%2FJjReuUy5e798%3D&reserved=0 pull/1523/head:pull/1523

PR: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openjdk.java.net%2Fjdk%2Fpull%2F1523&data=04%7C01%7Cmatthew.carter%40microsoft.com%7C064ac0511f8d456a8f0108d89618859e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637424379353506711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tDt7IKZIie43WPEiWvVEiqoGBvIg6erjxbqLw%2BqUzAg%3D&reserved=0

AlanBateman

Looks good.

openjdk · 2020-12-23T16:10:55Z

@macarte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255264: Support for identifying the full range of IPv4 localhost addresses on Windows

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 406 new commits pushed to the master branch:

91244cc: 8258557: Deproblemlist fixed problemlisted test
2445735: 8258837: Remove JVM option DisableStartThread
a4e082e: 8253368: TLS connection always receives close_notify exception
4ea8851: 8257928: Test image build failure with clang-10 due to -Wmisleading-indentation
f2bad3a: Merge
61e5e39: 8258832: ProblemList com/sun/jdi/AfterThreadDeathTest.java on Linux-X64
eabc903: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows
88dd6a9: 8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java
772addf: 8258790: C2: Crash on empty macro node list
8da7c58: 8258443: doclint should be service-loaded with system class loader
... and 396 more: https://git.openjdk.java.net/jdk/compare/65137ff02c015891a2e1ecb9da03919f0a675cf2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

macarte · 2020-12-23T17:20:53Z

Thanks for the review Alan

/integrate

openjdk · 2020-12-23T17:21:24Z

@macarte
Your change (at version deeae3d) is now ready to be sponsored by a Committer.

AlanBateman · 2021-01-06T10:38:34Z

/sponsor

openjdk · 2021-01-06T10:39:23Z

@AlanBateman @macarte Since your change was applied there have been 460 commits pushed to the master branch:

8a05d60: 8259042: Inconsistent use of general primitives loops
e3b9da1: 8259287: AbstractCompiler marks const in wrong position for is_c1/is_c2/is_jvmci
32538b5: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
52d3fee: 8258813: [TESTBUG] Fix incorrect Vector API test output message
8b45497: 8259037: livenmethods cannot find hsdis library
7d76966: 8255757: Javac emits duplicate pool entries on array::clone
cf9908b: 8258937: Remove JVM IgnoreRewrites flag
4d3d599: 8259223: Simplify boolean expression in the SunJSSE provider
1b60acd: 8259252: Shenandoah: Shenandoah build failed on AArch64 after JDK-8258459
7ddc2b5: 8258852: Arrays.asList() for single item could be replaced with List.of()
... and 450 more: https://git.openjdk.java.net/jdk/compare/65137ff02c015891a2e1ecb9da03919f0a675cf2...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7e01bc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk · 2021-10-27T21:59:26Z

@macarte Unknown command backport - for a list of valid commands use /help.

8255264: Support for identifying the full range of IPv4 localhost add…

deeae3d

…resses on Windows

bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 30, 2020

openjdk bot added the net net-dev@openjdk.org label Nov 30, 2020

bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Nov 30, 2020

bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Dec 1, 2020

openjdk bot added the rfr Pull request is ready for review label Dec 1, 2020

AlanBateman approved these changes Dec 23, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2020

openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 23, 2020

openjdk bot closed this Jan 6, 2021

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8255264: Support for identifying the full range of IPv4 localhost addresses on Windows #1523

8255264: Support for identifying the full range of IPv4 localhost addresses on Windows #1523

macarte commented Nov 30, 2020 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 30, 2020

macarte commented Nov 30, 2020

openjdk bot commented Nov 30, 2020

bridgekeeper bot commented Nov 30, 2020

mlbridge bot commented Dec 1, 2020

mlbridge bot commented Dec 8, 2020

AlanBateman left a comment

openjdk bot commented Dec 23, 2020 •

edited

Loading

macarte commented Dec 23, 2020

openjdk bot commented Dec 23, 2020

AlanBateman commented Jan 6, 2021

openjdk bot commented Jan 6, 2021

openjdk bot commented Oct 27, 2021

8255264: Support for identifying the full range of IPv4 localhost addresses on Windows #1523

8255264: Support for identifying the full range of IPv4 localhost addresses on Windows #1523

Conversation

macarte commented Nov 30, 2020 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Download

bridgekeeper bot commented Nov 30, 2020

macarte commented Nov 30, 2020

openjdk bot commented Nov 30, 2020

bridgekeeper bot commented Nov 30, 2020

mlbridge bot commented Dec 1, 2020

Webrevs

mlbridge bot commented Dec 8, 2020

AlanBateman left a comment

Choose a reason for hiding this comment

openjdk bot commented Dec 23, 2020 • edited Loading

macarte commented Dec 23, 2020

openjdk bot commented Dec 23, 2020

AlanBateman commented Jan 6, 2021

openjdk bot commented Jan 6, 2021

openjdk bot commented Oct 27, 2021

macarte commented Nov 30, 2020 •

edited by openjdk bot

Loading

openjdk bot commented Dec 23, 2020 •

edited

Loading