Skip to content

8314078: HotSpotConstantPool.lookupField() asserts due to field changes in ConstantPool.cpp #15237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

8314078: HotSpotConstantPool.lookupField() asserts due to field changes in ConstantPool.cpp #15237

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6527e67
8314078: HotSpotConstantPool.lookupField() asserts due to field chang…
iklam Aug 11, 2023
c322b8e
(no actual code changes) Fixed variable names and javadoc so that cha…
iklam Aug 11, 2023
21976c0
@dougxc review: Added comments about rawIndex vs cpi
iklam Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/ConstantPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@
* Represents the runtime representation of the constant pool that is used by the compiler when
* parsing bytecode. Provides methods to look up a constant pool entry without performing
* resolution. They are used during compilation.
*
* The following convention is used when accessing the ConstantPool with an index:
* <ul>
* <li>rawIndex - index in the bytecode stream after the opcode (could be rewritten for some opcodes)</li>
* <li>cpi - the constant pool index (as specified in JVM Spec)</li>
* </ul>
*
* Some of the methods are currently not using the convention correctly. That will be addressed in JDK-8314172.
*/
public interface ConstantPool {

Expand All @@ -44,7 +52,7 @@ public interface ConstantPool {
* initialized. This can be used to compile time resolve a type. It works for field, method, or
* type constant pool entries.
*
* @param rawIndex index in the bytecode stream after the {@code opcode} (could be rewritten for some bytecodes)
* @param rawIndex index in the bytecode stream after the {@code opcode} (could be rewritten for some opcodes)
* @param opcode the opcode of the instruction that references the type
*/
void loadReferencedType(int rawIndex, int opcode);
Expand All @@ -54,7 +62,7 @@ public interface ConstantPool {
* used to compile time resolve a type. It works for field, method, or type constant pool
* entries.
*
* @param rawIndex index in the bytecode stream after the {@code opcode} (could be rewritten for some bytecodes)
* @param rawIndex index in the bytecode stream after the {@code opcode} (could be rewritten for some opcodes)
* @param opcode the opcode of the instruction that references the type
* @param initialize if {@code true}, the referenced type is either guaranteed to be initialized
* upon return or an initialization exception is thrown
Expand All @@ -70,7 +78,7 @@ default void loadReferencedType(int rawIndex, int opcode, boolean initialize) {
/**
* Looks up the type referenced by the {@code rawIndex}.
*
* @param rawIndex index in the bytecode stream after the {@code opcode} (could be rewritten for some bytecodes)
* @param rawIndex index in the bytecode stream after the {@code opcode} (could be rewritten for some opcodes)
* @param opcode the opcode of the instruction with {@code rawIndex} as an operand
* @return a reference to the compiler interface type
*/
Expand Down