Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp #15246

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Aug 11, 2023

Hi all,

please review this change to disable running these tests with -Xcomp to avoid unnecessary failures due to e.g. code cache getting full.

In order to avoid the same issue with the IHOP ergo test, do the same there. Running these tests with -Xcomp is not expected to yield any significant additional failures anyway.

Testing: gha, failing test with/without this change.

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15246/head:pull/15246
$ git checkout pull/15246

Update a local copy of the PR:
$ git checkout pull/15246
$ git pull https://git.openjdk.org/jdk.git pull/15246/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15246

View PR using the GUI difftool:
$ git pr show -t 15246

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15246.diff

Webrev

Link to Webrev Comment

disable -Xcomp in IHOP tests to aovid additional random concurrent markings
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2023

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8314144 8314144: Aug 11, 2023
@openjdk
Copy link

openjdk bot commented Aug 11, 2023

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 11, 2023
@tschatzl tschatzl changed the title 8314144: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp Aug 11, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 11, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 11, 2023

Webrevs

@tschatzl
Copy link
Contributor Author

Thanks @walulyai @albertnetymk for your reviews

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@tschatzl This pull request has not yet been marked as ready for integration.

@tschatzl
Copy link
Contributor Author

(bump)

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

  • b80001d: 8314209: Wrong @SInCE tag for RandomGenerator::equiDoubles
  • ef6db5c: 8314211: Add NativeLibraryUnload event
  • 49ddb19: 8313760: [REDO] Enhance AES performance
  • d46f0fb: 8313720: C2 SuperWord: wrong result with -XX:+UseVectorCmov -XX:+UseCMoveUnconditionally
  • 38687f1: 8314262: GHA: Cut down cross-compilation sysroots deeper
  • a602624: 8314020: Print instruction blocks in byte units
  • 0b12480: 8314233: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: unexpected
  • e1fdef5: 8314324: "8311557: [JVMCI] deadlock with JVMTI thread suspension" causes various failures
  • 2bd2fae: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge
  • 6a15860: 8314163: os::print_hex_dump prints incorrectly for big endian platforms and unit sizes larger than 1
  • ... and 75 more: https://git.openjdk.org/jdk/compare/52ec4bcb1bab15dbf0a9b2488d33a23cdc1cb0e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 16, 2023
@tschatzl
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

Going to push as commit 1925508.
Since your change was applied there have been 85 commits pushed to the master branch:

  • b80001d: 8314209: Wrong @SInCE tag for RandomGenerator::equiDoubles
  • ef6db5c: 8314211: Add NativeLibraryUnload event
  • 49ddb19: 8313760: [REDO] Enhance AES performance
  • d46f0fb: 8313720: C2 SuperWord: wrong result with -XX:+UseVectorCmov -XX:+UseCMoveUnconditionally
  • 38687f1: 8314262: GHA: Cut down cross-compilation sysroots deeper
  • a602624: 8314020: Print instruction blocks in byte units
  • 0b12480: 8314233: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: unexpected
  • e1fdef5: 8314324: "8311557: [JVMCI] deadlock with JVMTI thread suspension" causes various failures
  • 2bd2fae: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge
  • 6a15860: 8314163: os::print_hex_dump prints incorrectly for big endian platforms and unit sizes larger than 1
  • ... and 75 more: https://git.openjdk.org/jdk/compare/52ec4bcb1bab15dbf0a9b2488d33a23cdc1cb0e1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2023
@openjdk openjdk bot closed this Aug 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@tschatzl Pushed as commit 1925508.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl
Copy link
Contributor Author

/backport jdk21u

@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@tschatzl the backport was successfully created on the branch tschatzl-backport-19255084 in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 19255084 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 16 Aug 2023 and was reviewed by Albert Mingkun Yang and Ivan Walulya.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git tschatzl-backport-19255084:tschatzl-backport-19255084
$ git checkout tschatzl-backport-19255084
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git tschatzl-backport-19255084

@tschatzl tschatzl deleted the submit/8314144-disable-xcomp branch August 18, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants