8314161: G1: Fix -Wconversion warnings in G1CardSetConfiguration::_bitmap_hash_mask

[albertnetymk]

Simple type change and updating to use more common mask-initialization.

Test: hotspot_gc

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314161: G1: Fix -Wconversion warnings in G1CardSetConfiguration::_bitmap_hash_mask (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15247/head:pull/15247
$ git checkout pull/15247

Update a local copy of the PR:
$ git checkout pull/15247
$ git pull https://git.openjdk.org/jdk.git pull/15247/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15247

View PR using the GUI difftool:
$ git pr show -t 15247

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15247.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1cc19327)

[tschatzl]

lgtm.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314161: G1: Fix -Wconversion warnings in G1CardSetConfiguration::_bitmap_hash_mask

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 101 new commits pushed to the master branch:

• 812f475: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
• 8939d15: 8314100: G1: Improve collection set candidate selection code
• ec1f7a8: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview)
• c50315d: 8314495: Update to use jtreg 7.3.1
• ed0f75f: 8313290: Misleading exception message from STS.Subtask::get when task forked after shutdown
• febc34d: 8314610: hotspot can't compile with the latest of gtest because of
• 58f5826: 8311222: strace004 can fail due to unexpected stack length after JDK-8309408
• 395fc78: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
• f481477: 8314320: Mark runtime/CommandLine/ tests as flagless
• fbe28ee: 8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed
• ... and 91 more: https://git.openjdk.org/jdk/compare/6ffc0324dc854c147ab92e5a597d10ed0166b34a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 0b3f452.
Since your change was applied there have been 102 commits pushed to the master branch:

• abac608: 8313962: G1: Refactor G1ConcurrentMark::_num_concurrent_workers
• 812f475: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
• 8939d15: 8314100: G1: Improve collection set candidate selection code
• ec1f7a8: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview)
• c50315d: 8314495: Update to use jtreg 7.3.1
• ed0f75f: 8313290: Misleading exception message from STS.Subtask::get when task forked after shutdown
• febc34d: 8314610: hotspot can't compile with the latest of gtest because of
• 58f5826: 8311222: strace004 can fail due to unexpected stack length after JDK-8309408
• 395fc78: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
• f481477: 8314320: Mark runtime/CommandLine/ tests as flagless
• ... and 92 more: https://git.openjdk.org/jdk/compare/6ffc0324dc854c147ab92e5a597d10ed0166b34a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 0b3f452.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.