8256718: Obsolete the long term deprecated and aliased Trace flags #1525

hseigel · 2020-11-30T21:13:05Z

Please review this change to obsolete the deprecated and aliased Trace flags. The now empty aliased_logging_flags support was left in arguments.cpp for use by trace flags that get deprecated and aliased in the future.

With this change, users will get the following example messages when using these obsolete flags, depending on whether -XX:+... or -XX:-... was specified:

VM warning: Ignoring option TraceClassPaths; support was removed in 16.0. Please use -Xlog:class+path=info instead.

VM warning: Ignoring option TraceClassPaths; support was removed in 16.0. Please use -Xlog:class+path=off instead.

The change was tested with tiers1and 2 on Linux, Windows, and MacOS, and tiers 3-5 on Linux x64 and with JCK lang and vm tests.

Thanks, Harold

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8256718: Obsolete the long term deprecated and aliased Trace flags

Reviewers

Serguei Spitsyn (@sspitsyn - Reviewer)
Ioi Lam (@iklam - Reviewer)
David Holmes (@dholmes-ora - Reviewer)
Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to 84e421f

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1525/head:pull/1525
$ git checkout pull/1525

bridgekeeper · 2020-11-30T21:13:38Z

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-11-30T21:14:40Z

@hseigel The following labels will be automatically applied to this pull request:

hotspot
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

hseigel · 2020-11-30T21:15:58Z

/label add hotspot-runtime

openjdk · 2020-11-30T21:16:34Z

@hseigel
The hotspot-runtime label was successfully added.

mlbridge · 2020-11-30T21:20:05Z

Webrevs

sspitsyn

Hi Harold,

The fix looks okay to me.
I was more focusing on the serviceability flags.
I'm not sure the flag TraceJVMTIObjectTagging should be mentioned in the src/java.base/share/man/java.1 the same way as the TraceRedefineClasses.

Thanks,
Serguei

openjdk · 2020-11-30T23:42:42Z

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256718: Obsolete the long term deprecated and aliased Trace flags

Reviewed-by: sspitsyn, iklam, dholmes, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

3da30e9: 8257241: CDS should not handle disableEagerInitialization for archived lambda proxy classes
7104400: 8257164: Share LambdaForms for VH linkers/invokers
3e89981: 8257623: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java shouldn't use timeout
93b6ab5: 8256818: SSLSocket that is never bound or connected leaks socket resources
692b273: 8257189: Handle concurrent updates of MH.form better
6704266: 8257565: epsilonBarrierSet.hpp should not include barrierSetAssembler
0b8c780: 8256256: UL should not use heap allocation for output string
2508bc7: 8257140: Crash in JvmtiTagMap::flush_object_free_events()
cfb50a9: 8253916: ResourceExhausted/resexhausted001 crashes on Linux-x64
287b829: 8254877: GCLogPrecious::_lock rank constrains what locks you are allowed to have when crashing
... and 47 more: https://git.openjdk.java.net/jdk/compare/6eb25d7cb42fb313172d90a56f231743cf6a7884...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

iklam

LGTM. Thanks for fixing the CDS tests.

dholmes-ora

Hi Harold,
I don't think we need to add all this new infrastructure for obsolete-aliased flags just so we can continue to print the -Xlog equivalents. I think simply adding these previously aliased flags as obsolete flags in the special flags table would suffice.
Thanks,
David

dholmes-ora · 2020-12-01T01:31:13Z

I should clarify this. I suggested in the bug report that we could continue to print the -Xlog equivalents, but when I wrote that I was thinking that the existing deprecated-aliased code would simply be changed to obsoleted-aliased code. I didn't consider that we might need to keep the deprecated-aliased code for future conversions to UL. But I can see now that we might want to do that. In which case I'd prefer to no longer print the -Xlog equivalents, rather than duplicate the deprecated-aliased code into an obsolete-aliased form.
My intent was to get rid of this special aliased flag handling code in the near future.
Thanks,
David

coleenp

I agree with David. We should remove the helpful messages at least for most of the obsolete Print/Trace flags. Not sure about the big 3 though.

src/hotspot/share/runtime/arguments.cpp

coleenp · 2020-12-01T12:04:43Z

src/hotspot/share/runtime/arguments.cpp

+  { "TraceJVMTIObjectTagging",   "-Xlog:jvmti+objecttagging=", "debug", "16.0" },
+  { "TraceRedefineClasses",      "-Xlog:redefine+class=",      "info",  "16.0" },
+  { "PrintJNIResolving",         "-Xlog:jni+resolve=",         "debug", "16.0" },
+  { NULL, NULL, NULL, NULL }


I think if we wanted to give a message that the flag was obsolete and to suggest changing the command line, we should only do it for -XX:+TraceClassLoading and -XX:+TraceExceptions (I'd originally thought -XX:+TraceClassUnloading was important enough to release note but now I'm not so sure.) The rest of the flags should either go in the table that they're no longer recognized.

Keeping the message for any flag requires keeping all the supporting code. I don't see the "big 3" are special. They have been deprecated since 9 and we have clearly told people this when they use them. We're also release-noting this for 16 (again - this was documented when UL was added). I don't think we have to pander to anyone who hasn't updated their launch scripts by now.

For these three, I kind of like the pandering. I'm not sure that the release note will reach people using these, especially -XX:+TraceExceptions. I guess they've been getting a deprecation message since 9 so maybe it won't be such a surprise. I never stand in the way of removing code that people won't need, if you think this is the case.

I think we should remove them. There is a risk that the user might not notice the difference between the old and new messages and so not realize they don't actually have active logging any more (until they go to access the logs to diagnose a problem).

src/hotspot/share/runtime/arguments.cpp

hseigel · 2020-12-01T21:46:17Z

Thanks everyone for the reviews. Please review the updated commit which contains the following changes:

Moves most of the flags to the normal location for obsolete flags.
Keeps the extra -Xlog message for the three most commonly used flags.
Removes the removed_develop_logging_flags struct and support functions.
Removes the aliased_logging_flags struct and support functions based on Coleen's statement that there are no existing flags that would use it.

Thanks! Harold

coleenp

I approve if you remove or leave the big 3 as aliases.

dholmes-ora

I'm still pushing for treating all flags the same and removing all the aliased-flag code.

Coleen seems to be okay either way. :)

Thanks,
David

dholmes-ora · 2020-12-02T02:34:21Z

src/hotspot/share/runtime/arguments.cpp

+  { "TraceJVMTIObjectTagging",   "-Xlog:jvmti+objecttagging=", "debug", "16.0" },
+  { "TraceRedefineClasses",      "-Xlog:redefine+class=",      "info",  "16.0" },
+  { "PrintJNIResolving",         "-Xlog:jni+resolve=",         "debug", "16.0" },
+  { NULL, NULL, NULL, NULL }


I think we should remove them. There is a risk that the user might not notice the difference between the old and new messages and so not realize they don't actually have active logging any more (until they go to access the logs to diagnose a problem).

hseigel · 2020-12-02T18:49:20Z

Please review this latest webrev. It removes all the aliasing code for the obsolete tracing flags and does not suggest logging alternatives in their obsolete flag messages.

Thanks, Harold

sspitsyn

The update looks good to me. It is a nice simplification.

dholmes-ora

Looks good!

Thanks,
David

hseigel · 2020-12-03T13:14:14Z

/integrate

hseigel · 2020-12-03T13:14:49Z

Thanks Coleen, Ioi, Serguei, and David for all the reviews.
Harold

openjdk · 2020-12-03T13:15:27Z

@hseigel Since your change was applied there have been 66 commits pushed to the master branch:

4a267f1: 8244847: Linux/PPC: runtime/CompressedOops/CompressedClassPointers: smallHeapTest fails
b44a329: 8256864: [windows] Improve tracing for mapping errors
ae1eb28: 8257604: JNI_ArgumentPusherVaArg leaks valist
4169d96: 8257143: Enable JVMCI code installation tests on AArch64
a5a034b: 8257617: TestLinkPlatform fails with new Java source version
d80ae05: 8166596: TLS support for the EdDSA signature algorithm
3932527: 8257466: Improve enum iteration
02a0a02: 8257563: Remove excessive include of klass.inline.hpp
cc1915b: 8253821: Improve ByteBuffer performance with GCM
3da30e9: 8257241: CDS should not handle disableEagerInitialization for archived lambda proxy classes
... and 56 more: https://git.openjdk.java.net/jdk/compare/6eb25d7cb42fb313172d90a56f231743cf6a7884...master

Your commit was automatically rebased without conflicts.

Pushed as commit e4497c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8256718: Obsolete the long term deprecated and aliased Trace flags

9c373c6

openjdk bot added the rfr Pull request is ready for review label Nov 30, 2020

openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Nov 30, 2020

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 30, 2020

sspitsyn approved these changes Nov 30, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2020

iklam approved these changes Dec 1, 2020

View reviewed changes

dholmes-ora reviewed Dec 1, 2020

View reviewed changes

coleenp suggested changes Dec 1, 2020

View reviewed changes

8256718: Obsolete the long term deprecated and aliased Trace flags

84e421f

iklam approved these changes Dec 1, 2020

View reviewed changes

coleenp approved these changes Dec 2, 2020

View reviewed changes

dholmes-ora suggested changes Dec 2, 2020

View reviewed changes

8256718: Obsolete the long term deprecated and aliased Trace flags

2c5bec9

sspitsyn approved these changes Dec 2, 2020

View reviewed changes

iklam approved these changes Dec 2, 2020

View reviewed changes

dholmes-ora approved these changes Dec 2, 2020

View reviewed changes

openjdk bot closed this Dec 3, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8256718: Obsolete the long term deprecated and aliased Trace flags #1525

8256718: Obsolete the long term deprecated and aliased Trace flags #1525

hseigel commented Nov 30, 2020 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 30, 2020

openjdk bot commented Nov 30, 2020

hseigel commented Nov 30, 2020

openjdk bot commented Nov 30, 2020

mlbridge bot commented Nov 30, 2020 •

edited

Loading

sspitsyn left a comment

openjdk bot commented Nov 30, 2020 •

edited

Loading

iklam left a comment

dholmes-ora left a comment

dholmes-ora commented Dec 1, 2020

coleenp left a comment

coleenp Dec 1, 2020

dholmes-ora Dec 1, 2020

coleenp Dec 2, 2020

dholmes-ora Dec 2, 2020

hseigel commented Dec 1, 2020

coleenp left a comment

dholmes-ora left a comment

dholmes-ora Dec 2, 2020

hseigel commented Dec 2, 2020

sspitsyn left a comment

dholmes-ora left a comment

hseigel commented Dec 3, 2020

hseigel commented Dec 3, 2020

openjdk bot commented Dec 3, 2020

8256718: Obsolete the long term deprecated and aliased Trace flags #1525

8256718: Obsolete the long term deprecated and aliased Trace flags #1525

Conversation

hseigel commented Nov 30, 2020 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Download

bridgekeeper bot commented Nov 30, 2020

openjdk bot commented Nov 30, 2020

hseigel commented Nov 30, 2020

openjdk bot commented Nov 30, 2020

mlbridge bot commented Nov 30, 2020 • edited Loading

Webrevs

sspitsyn left a comment

Choose a reason for hiding this comment

openjdk bot commented Nov 30, 2020 • edited Loading

iklam left a comment

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora commented Dec 1, 2020

coleenp left a comment

Choose a reason for hiding this comment

coleenp Dec 1, 2020

Choose a reason for hiding this comment

dholmes-ora Dec 1, 2020

Choose a reason for hiding this comment

coleenp Dec 2, 2020

Choose a reason for hiding this comment

dholmes-ora Dec 2, 2020

Choose a reason for hiding this comment

hseigel commented Dec 1, 2020

coleenp left a comment

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora Dec 2, 2020

Choose a reason for hiding this comment

hseigel commented Dec 2, 2020

sspitsyn left a comment

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

hseigel commented Dec 3, 2020

hseigel commented Dec 3, 2020

openjdk bot commented Dec 3, 2020

hseigel commented Nov 30, 2020 •

edited by openjdk bot

Loading

mlbridge bot commented Nov 30, 2020 •

edited

Loading

openjdk bot commented Nov 30, 2020 •

edited

Loading