JDK-8314197: AttachListener::pd_find_operation always returning nullptr

[MBaesken]

AttachListener::pd_find_operation always returns nullptr and seems to be obsolete, so we could probably remove it and clean up the coding a bit.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314197: AttachListener::pd_find_operation always returning nullptr (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Chris Plummer (@plummercj - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15265/head:pull/15265
$ git checkout pull/15265

Update a local copy of the PR:
$ git checkout pull/15265
$ git pull https://git.openjdk.org/jdk.git pull/15265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15265

View PR using the GUI difftool:
$ git pr show -t 15265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15265.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following labels will be automatically applied to this pull request:

• hotspot-runtime
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (64c10e0d)

[dholmes-ora]

Looks good and trivial.

The last platform to have a non-empty implementation was Solaris, so this should have been removed when the Solaris port was removed.

Thanks.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314197: AttachListener::pd_find_operation always returning nullptr

Reviewed-by: dholmes, cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 583cb75: 8313406: nep_invoker_blob can be simplified more
• 0074b48: 8312597: Convert TraceTypeProfile to UL
• 1f1c5c6: 8314241: Add test/jdk/sun/security/pkcs/pkcs7/SignerOrder.java to ProblemList
• f142470: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out
• 595fdd3: 8314059: Remove PKCS7.verify()
• 49b2984: 8313854: Some tests in serviceability area fail on localized Windows platform
• c132176: 8114830: (fs) Files.copy fails due to interference from something else changing the file system
• e56d3bc: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
• 4b2703a: 8313678: SymbolTable can leak Symbols during cleanup
• f41c267: 8314045: ArithmeticException in GaloisCounterMode
• ... and 10 more: https://git.openjdk.org/jdk/compare/5c9162288570a140138a0055cd9c4e88fe40e69d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[MBaesken]

Hi David, thanks for the review ! If it is 'trivial' , afaik one review is sufficient, is that correct ?

[MBaesken]

Hi Chris and Serguei, thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 6338927.
Since your change was applied there have been 22 commits pushed to the master branch:

• b7dee21: 8314244: Incorrect file headers in new tests from JDK-8312597
• 37c6b23: 8308340: C2: Idealize Fma nodes
• 583cb75: 8313406: nep_invoker_blob can be simplified more
• 0074b48: 8312597: Convert TraceTypeProfile to UL
• 1f1c5c6: 8314241: Add test/jdk/sun/security/pkcs/pkcs7/SignerOrder.java to ProblemList
• f142470: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out
• 595fdd3: 8314059: Remove PKCS7.verify()
• 49b2984: 8313854: Some tests in serviceability area fail on localized Windows platform
• c132176: 8114830: (fs) Files.copy fails due to interference from something else changing the file system
• e56d3bc: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
• ... and 12 more: https://git.openjdk.org/jdk/compare/5c9162288570a140138a0055cd9c4e88fe40e69d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 6338927.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.