Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313760: [REDO] Enhance AES performance #15267

Closed
wants to merge 1 commit into from

Conversation

chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Aug 14, 2023

This reapplies JDK-8308682 (i.e. reverse the backout done with JDK-8313756) but attributes it correctly to @theRealAph together with @adinn and @sviswa7 as additional reviewers.

The redo applied cleanly.

Thanks,
Christian


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313760: [REDO] Enhance AES performance (Bug - P2)

Reviewers

Contributors

  • Andrew Haley <aph@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15267/head:pull/15267
$ git checkout pull/15267

Update a local copy of the PR:
$ git checkout pull/15267
$ git pull https://git.openjdk.org/jdk.git pull/15267/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15267

View PR using the GUI difftool:
$ git pr show -t 15267

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15267.diff

Webrev

Link to Webrev Comment

@chhagedorn
Copy link
Member Author

/contributor add @theRealAph

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 14, 2023

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@chhagedorn
Copy link
Member Author

/reviewer credit @adinn

@chhagedorn
Copy link
Member Author

/reviewer credit @sviswa7

@chhagedorn
Copy link
Member Author

/reviewer credit @vnkozlov

@chhagedorn
Copy link
Member Author

/reviewer credit @dean-long

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@chhagedorn
Contributor Andrew Haley <aph@openjdk.org> successfully added.

@chhagedorn
Copy link
Member Author

/reviewer credit @rhalade

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@chhagedorn
Reviewer adinn successfully credited.

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@chhagedorn
Reviewer sviswanathan successfully credited.

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@chhagedorn
Reviewer kvn successfully credited.

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@chhagedorn
Reviewer dlong successfully credited.

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@chhagedorn
Reviewer rhalade successfully credited.

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@chhagedorn The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 14, 2023
@chhagedorn
Copy link
Member Author

/label remove hotspot

@chhagedorn
Copy link
Member Author

/label add hotspot-compiler

@openjdk openjdk bot removed the hotspot hotspot-dev@openjdk.org label Aug 14, 2023
@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@chhagedorn
The hotspot label was successfully removed.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 14, 2023
@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@chhagedorn
The hotspot-compiler label was successfully added.

@chhagedorn chhagedorn marked this pull request as ready for review August 14, 2023 12:29
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 14, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 14, 2023

Webrevs

Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine, thanks!

@chhagedorn
Copy link
Member Author

Thanks @adinn! I think you additionally need to approve it since the bot does not accept only manually added reviewers.

Copy link
Contributor

@theRealAph theRealAph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@openjdk
Copy link

openjdk bot commented Aug 15, 2023

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313760: [REDO] Enhance AES performance

Co-authored-by: Andrew Haley <aph@openjdk.org>
Reviewed-by: adinn, aph, sviswanathan, rhalade, kvn, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 38687f1: 8314262: GHA: Cut down cross-compilation sysroots deeper
  • a602624: 8314020: Print instruction blocks in byte units
  • 0b12480: 8314233: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: unexpected
  • e1fdef5: 8314324: "8311557: [JVMCI] deadlock with JVMTI thread suspension" causes various failures
  • 2bd2fae: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge
  • 6a15860: 8314163: os::print_hex_dump prints incorrectly for big endian platforms and unit sizes larger than 1
  • 6bf4a33: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • bc8e9f4: 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder
  • 0f5e030: 8309335: Get rid of use of reflection to call Thread.isVirtual() in nsk/jdi/EventRequestManager/stepRequests/stepreq001t.java
  • f66c73d: 8314166: Update googletest to v1.14.0
  • ... and 23 more: https://git.openjdk.org/jdk/compare/207bd00c5101fce06b5ac12e76893d989b0093e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 15, 2023
@chhagedorn
Copy link
Member Author

Thanks @theRealAph for your review!

For some reason, @adinn was removed again as reviewer by the bot. I'll add him again.

@chhagedorn
Copy link
Member Author

/reviewer credit @adinn

@openjdk
Copy link

openjdk bot commented Aug 15, 2023

@chhagedorn Reviewer adinn has already made an authenticated review of this PR, and does not need to be credited manually.

@chhagedorn
Copy link
Member Author

@chhagedorn Reviewer adinn has already made an authenticated review of this PR, and does not need to be credited manually.

@adinn I'm not sure why it says that but does not list you above. Maybe you need to explicitly approve the PR again to appear in the reviewer list again.

@kevinrushforth
Copy link
Member

Reviewer adinn has already made an authenticated review of this PR, and does not need to be credited manually.

@adinn I'm not sure why it says that but does not list you above. Maybe you need to explicitly approve the PR again to appear in the reviewer list again.

Yes, GitHub now sees @adinn as having reviewed, but without approving it, so Skara will not allow him to be added manually. If he reviews / approves, he will then be listed.

@chhagedorn
Copy link
Member Author

Thanks @kevinrushforth for the explanation!

Copy link

@sviswa7 sviswa7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chhagedorn
Copy link
Member Author

Thanks @adinn, @theRealAph, @sviswa7, and @rhalade for approving this REDO! Sanity testing looked good.

@chhagedorn
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

Going to push as commit 49ddb19.
Since your change was applied there have been 34 commits pushed to the master branch:

  • d46f0fb: 8313720: C2 SuperWord: wrong result with -XX:+UseVectorCmov -XX:+UseCMoveUnconditionally
  • 38687f1: 8314262: GHA: Cut down cross-compilation sysroots deeper
  • a602624: 8314020: Print instruction blocks in byte units
  • 0b12480: 8314233: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: unexpected
  • e1fdef5: 8314324: "8311557: [JVMCI] deadlock with JVMTI thread suspension" causes various failures
  • 2bd2fae: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge
  • 6a15860: 8314163: os::print_hex_dump prints incorrectly for big endian platforms and unit sizes larger than 1
  • 6bf4a33: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • bc8e9f4: 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder
  • 0f5e030: 8309335: Get rid of use of reflection to call Thread.isVirtual() in nsk/jdi/EventRequestManager/stepRequests/stepreq001t.java
  • ... and 24 more: https://git.openjdk.org/jdk/compare/207bd00c5101fce06b5ac12e76893d989b0093e2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2023
@openjdk openjdk bot closed this Aug 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@chhagedorn Pushed as commit 49ddb19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@theRealAph
Copy link
Contributor

It's come through as co-authored-by instead of authored-by, which is wrong because I wrote every single byte, but never mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
6 participants