Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257445: (zipfs) Add DataProvider to TestLocOffsetFromZip64EF.java #1527

Closed
wants to merge 2 commits into from

Conversation

LanceAndersen
Copy link
Contributor

@LanceAndersen LanceAndersen commented Nov 30, 2020

HI all,

Please review this trivial change which adds a DataProvider to the manual test TestLocOffsetFromZip64EF.java, added as part of the fix for https://bugs.openjdk.java.net/browse/JDK-8255380, to specify additional values for the Zip FS file System property zipinfo-time.

Best,
Lance


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux additional Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (8/8 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (2/9 running) (3/9 running) ✔️ (9/9 passed)

Issue

  • JDK-8257445: (zipfs) Add DataProvider to TestLocOffsetFromZip64EF.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1527/head:pull/1527
$ git checkout pull/1527

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2020

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@LanceAndersen The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Nov 30, 2020
@LanceAndersen LanceAndersen changed the title (zipfs) Add DataProvider to TestLocOffsetFromZip64EF.java 8257445: (zipfs) Add DataProvider to TestLocOffsetFromZip64EF.java Nov 30, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2020

Webrevs

bplb
bplb approved these changes Nov 30, 2020
@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257445: (zipfs) Add DataProvider to TestLocOffsetFromZip64EF.java

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 29f86e0: 8256536: Newer AMD 19h (EPYC) Processor family defaults
  • 7f58a8e: 8213719: Both sect163r2 and sect163k1 are default curves for field size 163
  • ae5b526: 8257448: Clean duplicated non-null check in the SunJSSE provider implementation
  • 41dbc13: 8180352: Add Stream.toList() method

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2020
@LanceAndersen
Copy link
Contributor Author

LanceAndersen commented Dec 1, 2020

/integrate

@openjdk openjdk bot closed this Dec 1, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2020
@openjdk
Copy link

openjdk bot commented Dec 1, 2020

@LanceAndersen Since your change was applied there have been 4 commits pushed to the master branch:

  • 29f86e0: 8256536: Newer AMD 19h (EPYC) Processor family defaults
  • 7f58a8e: 8213719: Both sect163r2 and sect163k1 are default curves for field size 163
  • ae5b526: 8257448: Clean duplicated non-null check in the SunJSSE provider implementation
  • 41dbc13: 8180352: Add Stream.toList() method

Your commit was automatically rebased without conflicts.

Pushed as commit 11dad14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
2 participants