Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310134: NMT: thread count in Thread section of VM.native_memory output confusing with virtual threads #15277

Closed
wants to merge 1 commit into from

Conversation

gerard-ziemski
Copy link

@gerard-ziemski gerard-ziemski commented Aug 14, 2023

This is a very simple tweak that changes NMT memory monitor output from:

- Thread (reserved=19511KB, committed=19511KB) 
                            (thread #19) 
                            (stack: reserved=19456KB, committed=19456KB) 
                            (malloc=33KB #118) 
                            (arena=21KB #37) 

to

- Thread (reserved=19511KB, committed=19511KB) 
                            (threads #19) 
                            (stack: reserved=19456KB, committed=19456KB) 
                            (malloc=33KB #118) 
                            (arena=21KB #37) 

to signify that we are talking about "thread count of 19" and not "thread with id 19"

There are more opportunities to clean up the output, but that will be handled in a followup bug https://bugs.openjdk.org/browse/JDK-8314227

Tested locally with NMT gtests and jtreg and Mach5 tier1,2,3,4,5

jtreg -nr -va -jdk:./build/xcode/build/jdk/ test/hotspot/jtreg/runtime/NMT

gtestLauncher -jdk ./build/xcode/build/jdk/ --gtest_output=xml:test_result.xml --gtest_catch_exceptions=0 --gtest_filter="NMT*:os*" -XX:NativeMemoryTracking=summary


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310134: NMT: thread count in Thread section of VM.native_memory output confusing with virtual threads (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15277/head:pull/15277
$ git checkout pull/15277

Update a local copy of the PR:
$ git checkout pull/15277
$ git pull https://git.openjdk.org/jdk.git pull/15277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15277

View PR using the GUI difftool:
$ git pr show -t 15277

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15277.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 14, 2023

👋 Welcome back gziemski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@gerard-ziemski The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 14, 2023
Copy link
Contributor

@jdksjolen jdksjolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

I also read your comment in the bug, threads=X is probably the way to go. Good follow up ticket for addressing those issues.

@gerard-ziemski gerard-ziemski marked this pull request as ready for review August 14, 2023 20:38
@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@gerard-ziemski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310134: NMT: thread count in Thread section of VM.native_memory output confusing with virtual threads

Reviewed-by: jsjolen, dholmes, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • b7dee21: 8314244: Incorrect file headers in new tests from JDK-8312597
  • 37c6b23: 8308340: C2: Idealize Fma nodes
  • 583cb75: 8313406: nep_invoker_blob can be simplified more
  • 0074b48: 8312597: Convert TraceTypeProfile to UL
  • 1f1c5c6: 8314241: Add test/jdk/sun/security/pkcs/pkcs7/SignerOrder.java to ProblemList
  • f142470: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out
  • 595fdd3: 8314059: Remove PKCS7.verify()
  • 49b2984: 8313854: Some tests in serviceability area fail on localized Windows platform
  • c132176: 8114830: (fs) Files.copy fails due to interference from something else changing the file system
  • e56d3bc: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • ... and 18 more: https://git.openjdk.org/jdk/compare/12326770dc4116dd3b374c3a50fabfa1f27249dd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 14, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 14, 2023

Webrevs

@dcubed-ojdk
Copy link
Member

At the risk of starting another round of bike shedding...

Does the "with virtual threads" suffix on the PR and the bug make sense anymore?

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial. Thanks.

@gerard-ziemski
Copy link
Author

Thank you all for the reviews!

@gerard-ziemski
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 15, 2023

Going to push as commit f239954.
Since your change was applied there have been 36 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 15, 2023
@openjdk openjdk bot closed this Aug 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 15, 2023
@openjdk
Copy link

openjdk bot commented Aug 15, 2023

@gerard-ziemski Pushed as commit f239954.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
5 participants