8314248: Remove HotSpotConstantPool::isResolvedDynamicInvoke

[iklam]

This method is not used and its implementation is wrong. It should be removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314248: Remove HotSpotConstantPool::isResolvedDynamicInvoke (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Doug Simon (@dougxc - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15283/head:pull/15283
$ git checkout pull/15283

Update a local copy of the PR:
$ git checkout pull/15283
$ git pull https://git.openjdk.org/jdk.git pull/15283/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15283

View PR using the GUI difftool:
$ git pr show -t 15283

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15283.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1d765371)

[TobiHartmann]

Looks good to me but JVMCI experts should also review this (@dougxc).

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314248: Remove HotSpotConstantPool::isResolvedDynamicInvoke

Reviewed-by: thartmann, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• b7dee21: 8314244: Incorrect file headers in new tests from JDK-8312597

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

LGTM. I think this is a leftover from jaotc.

[iklam]

Thanks @TobiHartmann and @dougxc for the review.
/integrate

[openjdk]

Going to push as commit 80809ef.
Since your change was applied there have been 7 commits pushed to the master branch:

• 004651d: 8311557: [JVMCI] deadlock with JVMTI thread suspension
• 9ded868: 8314114: Fix -Wconversion warnings in os code, primarily linux
• a02d65e: 8310308: IR Framework: check for type and size of vector nodes
• dff99f7: 8313782: Add user-facing warning if THPs are enabled but cannot be used
• f4e72c5: 8313949: Missing word in GPLv2 license text in StackMapTableAttribute.java
• 6338927: 8314197: AttachListener::pd_find_operation always returning nullptr
• b7dee21: 8314244: Incorrect file headers in new tests from JDK-8312597

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 80809ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.