8314268: Missing include in assembler_riscv.hpp

[robehn]

Hello, please consider.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314268: Missing include in assembler_riscv.hpp (Bug - P5)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15285/head:pull/15285
$ git checkout pull/15285

Update a local copy of the PR:
$ git checkout pull/15285
$ git pull https://git.openjdk.org/jdk.git pull/15285/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15285

View PR using the GUI difftool:
$ git pr show -t 15285

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15285.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robehn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9a007cd1)

[shipilev]

What's the symptom for the problem? Build failure in some unusual config? Or this is just a cleanliness ("use the symbol in the header, include the definition without relying on transitive includes")?

[robehn]

Just WIP local changes were I included assembler_riscv.hpp for Assebmler::LMUL, and notice this.

[shipilev]

It is a bit odd to do this without the actual bug, but I guess it is fine to proactively maintain the includes of headers that define the symbols we use in header definitions.

[openjdk]

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314268: Missing include in assembler_riscv.hpp

Reviewed-by: shade, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 0c3bc71: 8281169: Expand discussion of elements and types
• f143380: 8314240: test/jdk/sun/security/pkcs/pkcs7/SignerOrder.java fails to compile
• 6b396da: 8062795: (fs) Files.setPermissions requires read access when NOFOLLOW_LINKS specified
• 7b28d36: 8314330: java/foreign tests should respect vm flags when start new processes
• b32d641: 8311943: Cleanup usages of toLowerCase() and toUpperCase() in java.base
• 13f6450: 8313765: Invalid CEN header (invalid zip64 extra data field size)
• 24e896d: 8310275: Bug in assignment operator of ReservedMemoryRegion
• 1925508: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp
• b80001d: 8314209: Wrong @SInCE tag for RandomGenerator::equiDoubles
• ef6db5c: 8314211: Add NativeLibraryUnload event
• ... and 17 more: https://git.openjdk.org/jdk/compare/a02d65efccaab5bb7c2f2aad4a2eb5062f545ef8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealFYang]

Just WIP local changes were I included assembler_riscv.hpp for Assebmler::LMUL, and notice this.

I guess you might want to include "asm/assembler.inline.hpp" instead which would bring assembler_riscv.hpp?

[robehn]

Just WIP local changes were I included assembler_riscv.hpp for Assebmler::LMUL, and notice this.

I guess you might want to include "asm/assembler.inline.hpp" instead which would bring assembler_riscv.hpp?

It was in another hpp file.

If not, yes you are correct.

[robehn]

It is a bit odd to do this without the actual bug, but I guess it is fine to proactively maintain the includes of headers that define the symbols we use in header definitions.

I have done several, e.g. https://bugs.openjdk.org/browse/JDK-8226227
And other people also such as https://bugs.openjdk.org/browse/JDK-8230888

So I don't find it 'unusual'.

Thanks for review!

[robehn]

Thanks for review.

[robehn]

/integrate

[openjdk]

Going to push as commit e8f6b3e.
Since your change was applied there have been 36 commits pushed to the master branch:

• c634bdf: 8314444: Update jib-profiles.js to use JMH 1.37 devkit
• 2b81885: 8314071: Test java/foreign/TestByteBuffer.java timed out
• 32efd23: 8311939: Excessive allocation of Matcher.groups array
• ed585d1: 8314280: StructuredTaskScope.shutdown should document that the state of completing subtasks is not defined
• 6f1071f: 8314213: DocLint should warn about unknown standard tags
• 4331193: 8314423: Multiple patterns without unnamed variables
• 249dc37: 8314321: Remove unused field jdk.internal.util.xml.impl.Attrs.mAttrIdx
• b78f5a1: 8314076: ICC_ColorSpace#minVal/maxVal have the opposite description
• 2a1176b: 8314276: Improve PtrQueue API around size/capacity
• 0c3bc71: 8281169: Expand discussion of elements and types
• ... and 26 more: https://git.openjdk.org/jdk/compare/a02d65efccaab5bb7c2f2aad4a2eb5062f545ef8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robehn Pushed as commit e8f6b3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.