Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314262: GHA: Cut down cross-compilation sysroots deeper #15287

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 15, 2023

JDK-8294941 cut out some unused files in GHA sysroots. But I notice that even after that, we still have quite a bit of fluff there, especially in RISC-V sysroot. We can cut a bit deeper. Notably, we don't need runnable gcc in the sysroot, because we use the cross-compilation toolchain from the host.

This further saves bandwidth, cache size, etc. for actively developed projects.

Seeing the following improvements in sysroot sizes:

ARM:      64 MB ->  37 MB
AArch64:  80 MB ->  46 MB
S390X:    69 MB ->  41 MB
PPC64:    84 MB ->  51 MB
RISC-V:  287 MB ->  53 MB

Total:   584 MB -> 228 MB (-61%)

Additional testing:

  • GHA (cross-builds still work fine)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314262: GHA: Cut down cross-compilation sysroots deeper (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15287/head:pull/15287
$ git checkout pull/15287

Update a local copy of the PR:
$ git checkout pull/15287
$ git pull https://git.openjdk.org/jdk.git pull/15287/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15287

View PR using the GUI difftool:
$ git pr show -t 15287

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15287.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 15, 2023
@openjdk
Copy link

openjdk bot commented Aug 15, 2023

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 15, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 15, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314262: GHA: Cut down cross-compilation sysroots deeper

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 0f5e030: 8309335: Get rid of use of reflection to call Thread.isVirtual() in nsk/jdi/EventRequestManager/stepRequests/stepreq001t.java
  • f66c73d: 8314166: Update googletest to v1.14.0
  • f239954: 8310134: NMT: thread count in Thread section of VM.native_memory output confusing with virtual threads
  • 2e8a0ab: 8314120: Add tests for FileDescriptor.sync
  • 80809ef: 8314248: Remove HotSpotConstantPool::isResolvedDynamicInvoke
  • 004651d: 8311557: [JVMCI] deadlock with JVMTI thread suspension
  • 9ded868: 8314114: Fix -Wconversion warnings in os code, primarily linux
  • a02d65e: 8310308: IR Framework: check for type and size of vector nodes
  • dff99f7: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • f4e72c5: 8313949: Missing word in GPLv2 license text in StackMapTableAttribute.java
  • ... and 32 more: https://git.openjdk.org/jdk/compare/43462a36ab02b67d426c04d345868bd420b30c25...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 15, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

Going to push as commit 38687f1.
Since your change was applied there have been 49 commits pushed to the master branch:

  • a602624: 8314020: Print instruction blocks in byte units
  • 0b12480: 8314233: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: unexpected
  • e1fdef5: 8314324: "8311557: [JVMCI] deadlock with JVMTI thread suspension" causes various failures
  • 2bd2fae: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge
  • 6a15860: 8314163: os::print_hex_dump prints incorrectly for big endian platforms and unit sizes larger than 1
  • 6bf4a33: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • bc8e9f4: 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder
  • 0f5e030: 8309335: Get rid of use of reflection to call Thread.isVirtual() in nsk/jdi/EventRequestManager/stepRequests/stepreq001t.java
  • f66c73d: 8314166: Update googletest to v1.14.0
  • f239954: 8310134: NMT: thread count in Thread section of VM.native_memory output confusing with virtual threads
  • ... and 39 more: https://git.openjdk.org/jdk/compare/43462a36ab02b67d426c04d345868bd420b30c25...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2023
@openjdk openjdk bot closed this Aug 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@shipilev Pushed as commit 38687f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8314262-gha-sysroots-deeper branch August 24, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants