8314321: Remove unused field jdk.internal.util.xml.impl.Attrs.mAttrIdx

[turbanoff]

A field char mAttrIdx in the jdk.internal.util.xml.impl.Attrs class is unused and can be removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314321: Remove unused field jdk.internal.util.xml.impl.Attrs.mAttrIdx (Enhancement - P5)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Vyom Tewari (@vyommani - Committer)
• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15298/head:pull/15298
$ git checkout pull/15298

Update a local copy of the PR:
$ git checkout pull/15298
$ git pull https://git.openjdk.org/jdk.git pull/15298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15298

View PR using the GUI difftool:
$ git pr show -t 15298

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15298.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1038f355)

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314321: Remove unused field jdk.internal.util.xml.impl.Attrs.mAttrIdx

Reviewed-by: alanb, vtewari, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 13f6450: 8313765: Invalid CEN header (invalid zip64 extra data field size)
• 24e896d: 8310275: Bug in assignment operator of ReservedMemoryRegion
• 1925508: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp
• b80001d: 8314209: Wrong @SInCE tag for RandomGenerator::equiDoubles
• ef6db5c: 8314211: Add NativeLibraryUnload event
• 49ddb19: 8313760: [REDO] Enhance AES performance
• d46f0fb: 8313720: C2 SuperWord: wrong result with -XX:+UseVectorCmov -XX:+UseCMoveUnconditionally
• 38687f1: 8314262: GHA: Cut down cross-compilation sysroots deeper
• a602624: 8314020: Print instruction blocks in byte units
• 0b12480: 8314233: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: unexpected
• ... and 7 more: https://git.openjdk.org/jdk/compare/f23995465767fa7319d2f6fac62b6ec74c0e4986...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vyommani]

Looks OK to me.

[turbanoff]

/integrate

[openjdk]

Going to push as commit 249dc37.
Since your change was applied there have been 24 commits pushed to the master branch:

• b78f5a1: 8314076: ICC_ColorSpace#minVal/maxVal have the opposite description
• 2a1176b: 8314276: Improve PtrQueue API around size/capacity
• 0c3bc71: 8281169: Expand discussion of elements and types
• f143380: 8314240: test/jdk/sun/security/pkcs/pkcs7/SignerOrder.java fails to compile
• 6b396da: 8062795: (fs) Files.setPermissions requires read access when NOFOLLOW_LINKS specified
• 7b28d36: 8314330: java/foreign tests should respect vm flags when start new processes
• b32d641: 8311943: Cleanup usages of toLowerCase() and toUpperCase() in java.base
• 13f6450: 8313765: Invalid CEN header (invalid zip64 extra data field size)
• 24e896d: 8310275: Bug in assignment operator of ReservedMemoryRegion
• 1925508: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp
• ... and 14 more: https://git.openjdk.org/jdk/compare/f23995465767fa7319d2f6fac62b6ec74c0e4986...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit 249dc37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.