8250855: Address reliance on default constructors in the Java 2D APIs #153
Hi @ccleary-oracle, welcome to this OpenJDK project and thanks for contributing!
We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing
If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ccleary-oracle" as summary for the issue.
If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing
@ccleary-oracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the
@ccleary-oracle This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 137 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @mrserb) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type
Just for my curiosity, what issues can arise relying on default
It is an anti-pattern to rely on an implicit default constructor in a
1. The default constructor will have no API docs
2. You could end up with a public constructor in a class where you don't
3. In a class where you do intend a public constructor, if you later add
On 9/16/2020 11:53 PM, Peter Hull wrote:
@prrace @ccleary-oracle Since your change was applied there have been 138 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit 3495c19.
💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.