Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314324: "8311557: [JVMCI] deadlock with JVMTI thread suspension" causes various failures #15300

Closed
wants to merge 1 commit into from

Conversation

tkrodriguez
Copy link
Contributor

@tkrodriguez tkrodriguez commented Aug 15, 2023

I accidentally reversed the default in my refactor. Testing is in progress.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314324: "8311557: [JVMCI] deadlock with JVMTI thread suspension" causes various failures (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15300/head:pull/15300
$ git checkout pull/15300

Update a local copy of the PR:
$ git checkout pull/15300
$ git pull https://git.openjdk.org/jdk.git pull/15300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15300

View PR using the GUI difftool:
$ git pr show -t 15300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15300.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2023

👋 Welcome back never! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 15, 2023
@openjdk
Copy link

openjdk bot commented Aug 15, 2023

@tkrodriguez The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 15, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2023

Webrevs

@tkrodriguez tkrodriguez changed the title 8311557: [JVMCI] deadlock with JVMTI thread suspension cause various failures 8314324: 8311557: [JVMCI] deadlock with JVMTI thread suspension cause various failures Aug 15, 2023
@tkrodriguez tkrodriguez changed the title 8314324: 8311557: [JVMCI] deadlock with JVMTI thread suspension cause various failures 8314324: 8311557: [JVMCI] deadlock with JVMTI thread suspension causes various failures Aug 16, 2023
@tkrodriguez tkrodriguez changed the title 8314324: 8311557: [JVMCI] deadlock with JVMTI thread suspension causes various failures 8314324: "8311557: [JVMCI] deadlock with JVMTI thread suspension" causes various failures Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@tkrodriguez This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314324: "8311557: [JVMCI] deadlock with JVMTI thread suspension" causes various failures

Reviewed-by: cjplummer, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 6bf4a33: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • bc8e9f4: 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder
  • 0f5e030: 8309335: Get rid of use of reflection to call Thread.isVirtual() in nsk/jdi/EventRequestManager/stepRequests/stepreq001t.java
  • f66c73d: 8314166: Update googletest to v1.14.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 16, 2023
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tkrodriguez
Copy link
Contributor Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

Going to push as commit e1fdef5.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 2bd2fae: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge
  • 6a15860: 8314163: os::print_hex_dump prints incorrectly for big endian platforms and unit sizes larger than 1
  • 6bf4a33: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • bc8e9f4: 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder
  • 0f5e030: 8309335: Get rid of use of reflection to call Thread.isVirtual() in nsk/jdi/EventRequestManager/stepRequests/stepreq001t.java
  • f66c73d: 8314166: Update googletest to v1.14.0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2023
@openjdk openjdk bot closed this Aug 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@tkrodriguez Pushed as commit e1fdef5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants