Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8314426: runtime/os/TestTrimNative.java is failing on slow machines #15309

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Aug 16, 2023

SAP reported errors on slow machines. Patch hardens the test against that.

  • remove the grep for "Native Trimmer Stop" message, since that message is raced by the VM death and may not appear on slow machines
  • for the low-interval test, made the number of trims to happen dependent on the runtime of the test. On slow machines, we could run longer than 3 seconds and therefore see more trim messages

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314426: runtime/os/TestTrimNative.java is failing on slow machines (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15309/head:pull/15309
$ git checkout pull/15309

Update a local copy of the PR:
$ git checkout pull/15309
$ git pull https://git.openjdk.org/jdk.git pull/15309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15309

View PR using the GUI difftool:
$ git pr show -t 15309

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15309.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 16, 2023
@tstuefe tstuefe marked this pull request as ready for review August 22, 2023 10:06
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 22, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2023

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Aug 22, 2023

Attention @TheRealMDoerr and @MBaesken

@openjdk
Copy link

openjdk bot commented Aug 22, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314426: runtime/os/TestTrimNative.java is failing on slow machines

Reviewed-by: mbaesken, mdoerr, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

  • 69d900d: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f39fc0a: 8314738: Remove all occurrences of and support for @Revised
  • 6b9df03: 8311240: Eliminate usage of testcases.jar from TestMetaSpaceLog.java
  • 3e1b1bf: 8314688: VM build without C1 fails after JDK-8313372
  • 02ef859: 8313689: C2: compiler/c2/irTests/scalarReplacement/AllocationMergesTests.java fails intermittently with -XX:-TieredCompilation
  • ab86d23: 8250269: Replace ATTRIBUTE_ALIGNED with alignas
  • a66b5df: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected
  • 87298d2: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException
  • 78f74bc: 8314672: ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all and windows-x64
  • 17a19dc: 8311639: Replace currentTimeMillis() with nanoTime() in jtreg/gc
  • ... and 58 more: https://git.openjdk.org/jdk/compare/e1fdef56135c2987b128884ef632b64c32dd674a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 22, 2023
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving it!

OutputAnalyzer output = runTestWithOptions(
new String[] { "-XX:+UnlockExperimentalVMOptions", "-XX:TrimNativeHeapInterval=1" },
new String[] { TestTrimNative.Tester.class.getName(), "0" }
);
long ms2 = System.currentTimeMillis();
long runtime_ms = ms2 - ms1;
long maxTrimsExpected = runtime_ms;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment explaining why you assign this.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, minor nits.

test/hotspot/jtreg/runtime/os/TestTrimNative.java Outdated Show resolved Hide resolved
Co-authored-by: Aleksey Shipilëv <shipilev@amazon.de>
@tstuefe
Copy link
Member Author

tstuefe commented Aug 22, 2023

Thanks @TheRealMDoerr and @shipilev !

/integrate

@openjdk
Copy link

openjdk bot commented Aug 22, 2023

Going to push as commit 20e9478.
Since your change was applied there have been 68 commits pushed to the master branch:

  • 69d900d: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f39fc0a: 8314738: Remove all occurrences of and support for @Revised
  • 6b9df03: 8311240: Eliminate usage of testcases.jar from TestMetaSpaceLog.java
  • 3e1b1bf: 8314688: VM build without C1 fails after JDK-8313372
  • 02ef859: 8313689: C2: compiler/c2/irTests/scalarReplacement/AllocationMergesTests.java fails intermittently with -XX:-TieredCompilation
  • ab86d23: 8250269: Replace ATTRIBUTE_ALIGNED with alignas
  • a66b5df: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected
  • 87298d2: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException
  • 78f74bc: 8314672: ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all and windows-x64
  • 17a19dc: 8311639: Replace currentTimeMillis() with nanoTime() in jtreg/gc
  • ... and 58 more: https://git.openjdk.org/jdk/compare/e1fdef56135c2987b128884ef632b64c32dd674a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 22, 2023
@openjdk openjdk bot closed this Aug 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2023
@openjdk
Copy link

openjdk bot commented Aug 22, 2023

@tstuefe Pushed as commit 20e9478.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants