-
Notifications
You must be signed in to change notification settings - Fork 6.2k
JDK-8314489: Add javadoc index entries for java.lang.Math terms #15322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
Webrevs
|
AlanBateman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me. You might want to move the "For a" on L58 to the next line to avoid L58 stick out too much, up to you.
|
@jddarcy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
rgiulietti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about <i>semi-monotonic</i> on L.80?
Does it deserve to be tagged as <dfn> and indexed?
Good idea; added. The term "IEEE 754" is already index from various section titles so I didn't add an index item for that explicitly. |
Sure; I usually prefer to re-flow the paragraphs after the text changes are agreed to so the difference is easier to see along the way. |
|
/integrate |
|
Going to push as commit 3bb8afb.
Your commit was automatically rebased without conflicts. |
Use of javadoc search index feature; I'll re-flow paragraphs before pushing once the wording is agreed to.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15322/head:pull/15322$ git checkout pull/15322Update a local copy of the PR:
$ git checkout pull/15322$ git pull https://git.openjdk.org/jdk.git pull/15322/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15322View PR using the GUI difftool:
$ git pr show -t 15322Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15322.diff
Webrev
Link to Webrev Comment