Skip to content

8314495: Update to use jtreg 7.3.1#15323

Closed
sormuras wants to merge 2 commits intoopenjdk:masterfrom
sormuras:JDK-8314495-jtreg-7.3.1
Closed

8314495: Update to use jtreg 7.3.1#15323
sormuras wants to merge 2 commits intoopenjdk:masterfrom
sormuras:JDK-8314495-jtreg-7.3.1

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Aug 17, 2023

Please review the change to update to using jtreg 7.3,1.

The primary change is to the jib-profiles.js file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various TEST.ROOT files.

This change set also un-problem-lists tests from 360f65d

This change set also fixes:

Testing: tier1-tier5 OK


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314495: Update to use jtreg 7.3.1 (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15323/head:pull/15323
$ git checkout pull/15323

Update a local copy of the PR:
$ git checkout pull/15323
$ git pull https://git.openjdk.org/jdk.git pull/15323/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15323

View PR using the GUI difftool:
$ git pr show -t 15323

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15323.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@sormuras The following labels will be automatically applied to this pull request:

  • build
  • compiler
  • core-libs
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Aug 17, 2023
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks.

@sormuras sormuras marked this pull request as ready for review August 18, 2023 09:48
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314495: Update to use jtreg 7.3.1

Reviewed-by: dholmes, erikj, iris, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • ed0f75f: 8313290: Misleading exception message from STS.Subtask::get when task forked after shutdown
  • febc34d: 8314610: hotspot can't compile with the latest of gtest because of
  • 58f5826: 8311222: strace004 can fail due to unexpected stack length after JDK-8309408
  • 395fc78: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
  • f481477: 8314320: Mark runtime/CommandLine/ tests as flagless
  • fbe28ee: 8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed
  • 50a2ce0: 8310815: Clarify the name of the main class, services and provider classes in module descriptor
  • aecbb1b: 8314448: Coordinate DocLint and JavaDoc to report on unknown tags
  • bcba5e9: 8313419: Template interpreter produces no safepoint check for return bytecodes
  • c36e009: 8308984: Relativize last_sp (and top_frame_sp) in interpreter frames
  • ... and 25 more: https://git.openjdk.org/jdk/compare/b78f5a1068224d8b3cfe9e8fb38307ca07de741d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2023

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@sormuras
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

Going to push as commit c50315d.
Since your change was applied there have been 35 commits pushed to the master branch:

  • ed0f75f: 8313290: Misleading exception message from STS.Subtask::get when task forked after shutdown
  • febc34d: 8314610: hotspot can't compile with the latest of gtest because of
  • 58f5826: 8311222: strace004 can fail due to unexpected stack length after JDK-8309408
  • 395fc78: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
  • f481477: 8314320: Mark runtime/CommandLine/ tests as flagless
  • fbe28ee: 8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed
  • 50a2ce0: 8310815: Clarify the name of the main class, services and provider classes in module descriptor
  • aecbb1b: 8314448: Coordinate DocLint and JavaDoc to report on unknown tags
  • bcba5e9: 8313419: Template interpreter produces no safepoint check for return bytecodes
  • c36e009: 8308984: Relativize last_sp (and top_frame_sp) in interpreter frames
  • ... and 25 more: https://git.openjdk.org/jdk/compare/b78f5a1068224d8b3cfe9e8fb38307ca07de741d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2023
@openjdk openjdk bot closed this Aug 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@sormuras Pushed as commit c50315d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants