Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8303815: Improve Metaspace test speed #15324

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Aug 17, 2023

Small adjustments that cut down time needed for Metaspace tests:

gtests: 22 seconds -> 6 seconds
elastic metaspace jtreg tests: 36 seconds -> 15 seconds

For the jtreg tests, I preserve the option to execute them full time as manual tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303815: Improve Metaspace test speed (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15324/head:pull/15324
$ git checkout pull/15324

Update a local copy of the PR:
$ git checkout pull/15324
$ git pull https://git.openjdk.org/jdk.git pull/15324/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15324

View PR using the GUI difftool:
$ git pr show -t 15324

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15324.diff

Webrev

Link to Webrev Comment

@tstuefe tstuefe changed the title Jdk 8303815 improve metaspace test speed JDK-8303815: Improve Metaspace test speed Aug 17, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 17, 2023
@tstuefe tstuefe marked this pull request as ready for review August 17, 2023 11:10
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 17, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2023

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Aug 22, 2023

Friendly ping. This is quite trivial.

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303815: Improve Metaspace test speed

Reviewed-by: stefank, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

  • 3699666: 8313319: [linux] mmap should use MAP_FIXED_NOREPLACE if available
  • 3285a1e: 8314555: Build with mawk fails on Windows
  • 4a50e87: 8303852: current_stack_region() gets called twice unnecessarily
  • c077be4: 8314694: Separate checked_cast from globalDefinitions.hpp
  • 68815d5: 8314734: Remove unused field TypeVariableImpl.EMPTY_ANNOTATION_ARRAY
  • 57a322d: 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters
  • 38a9edf: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
  • 2c60cad: 8280743: HSDB "Monitor Cache Dump" command might throw NPE
  • 9435cd1: 8175874: Update Security.insertProviderAt to specify behavior when requested position is out of range.
  • dbb788f: 8294535: Add screen capture functionality to PassFailJFrame
  • ... and 71 more: https://git.openjdk.org/jdk/compare/b78f5a1068224d8b3cfe9e8fb38307ca07de741d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 23, 2023
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Thanks.

@tstuefe
Copy link
Member Author

tstuefe commented Aug 24, 2023

Thanks @stefank and @dholmes-ora

/integrate

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

Going to push as commit de0e46c.
Since your change was applied there have been 81 commits pushed to the master branch:

  • 3699666: 8313319: [linux] mmap should use MAP_FIXED_NOREPLACE if available
  • 3285a1e: 8314555: Build with mawk fails on Windows
  • 4a50e87: 8303852: current_stack_region() gets called twice unnecessarily
  • c077be4: 8314694: Separate checked_cast from globalDefinitions.hpp
  • 68815d5: 8314734: Remove unused field TypeVariableImpl.EMPTY_ANNOTATION_ARRAY
  • 57a322d: 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters
  • 38a9edf: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
  • 2c60cad: 8280743: HSDB "Monitor Cache Dump" command might throw NPE
  • 9435cd1: 8175874: Update Security.insertProviderAt to specify behavior when requested position is out of range.
  • dbb788f: 8294535: Add screen capture functionality to PassFailJFrame
  • ... and 71 more: https://git.openjdk.org/jdk/compare/b78f5a1068224d8b3cfe9e8fb38307ca07de741d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 24, 2023
@openjdk openjdk bot closed this Aug 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@tstuefe Pushed as commit de0e46c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants