Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails #15328

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 17, 2023

Current test expects G1HeapRegionSize flag to be printed out from jmap. But that one is not printed when Shenandoah is enabled. I opted for the minimally intrusive fix: move the additional Shenandoah printout to the Shenandoah-specific block.

Additional testing:

  • Affected test now passes with Shenandoah, continues to pass with G1, Serial, Parallel
  • sun/tools/jhsdb passes with {Serial, Parallel, G1, Shenandoah}
  • serviceability/sa passes with {Serial, Parallel, G1, Shenandoah}

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15328/head:pull/15328
$ git checkout pull/15328

Update a local copy of the PR:
$ git checkout pull/15328
$ git pull https://git.openjdk.org/jdk.git pull/15328/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15328

View PR using the GUI difftool:
$ git pr show -t 15328

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15328.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 17, 2023
@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org labels Aug 17, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • b33ff30: 8313661: [REDO] Relax prerequisites for java.base-jmod target
  • 62ca001: 8313357: Revisit requiring SA tests on OSX to either run as root or use sudo
  • 388dcff: 8282712: VMConnection.open() does not detect if VM failed to be created, resulting in NPE
  • e8f6b3e: 8314268: Missing include in assembler_riscv.hpp
  • c634bdf: 8314444: Update jib-profiles.js to use JMH 1.37 devkit
  • 2b81885: 8314071: Test java/foreign/TestByteBuffer.java timed out
  • 32efd23: 8311939: Excessive allocation of Matcher.groups array
  • ed585d1: 8314280: StructuredTaskScope.shutdown should document that the state of completing subtasks is not defined
  • 6f1071f: 8314213: DocLint should warn about unknown standard tags
  • 4331193: 8314423: Multiple patterns without unnamed variables
  • ... and 52 more: https://git.openjdk.org/jdk/compare/4164693f3bf15a2f3e03dee72e1ca3fb8d82582c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 17, 2023
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.
Thanks,
Serguei

@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

Going to push as commit 812f475.
Since your change was applied there have been 89 commits pushed to the master branch:

  • 8939d15: 8314100: G1: Improve collection set candidate selection code
  • ec1f7a8: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview)
  • c50315d: 8314495: Update to use jtreg 7.3.1
  • ed0f75f: 8313290: Misleading exception message from STS.Subtask::get when task forked after shutdown
  • febc34d: 8314610: hotspot can't compile with the latest of gtest because of
  • 58f5826: 8311222: strace004 can fail due to unexpected stack length after JDK-8309408
  • 395fc78: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
  • f481477: 8314320: Mark runtime/CommandLine/ tests as flagless
  • fbe28ee: 8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed
  • 50a2ce0: 8310815: Clarify the name of the main class, services and provider classes in module descriptor
  • ... and 79 more: https://git.openjdk.org/jdk/compare/4164693f3bf15a2f3e03dee72e1ca3fb8d82582c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2023
@openjdk openjdk bot closed this Aug 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@shipilev Pushed as commit 812f475.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8314501-shenandoah-jmapheapconfig branch August 24, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants