8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError #15329

yukikimmura · 2023-08-17T10:48:49Z

I would like to fix this issue because it is difficult for testers to understand why the test failed.
There is no risk as I just added an assertion message instead of exit code error.
I would appreciate it if someone could review the fix.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError (Bug - P4)

Reviewers

Aleksey Shipilev (@shipilev - Reviewer)
Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15329/head:pull/15329
$ git checkout pull/15329

Update a local copy of the PR:
$ git checkout pull/15329
$ git pull https://git.openjdk.org/jdk.git pull/15329/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15329

View PR using the GUI difftool:
$ git pr show -t 15329

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15329.diff

Webrev

Link to Webrev Comment

…lCountTest.java fails with java.lang.VirtualMachineError

bridgekeeper · 2023-08-17T10:49:36Z

👋 Welcome back yukikimmura! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-08-17T10:51:24Z

@yukikimmura The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-08-17T10:55:46Z

Webrevs

shipilev

Sorry, but we should not do this for two reasons:

We cannot be sure that non-zero exit code means we failed to create adapters.
stderr printout (as shown in the bug) provides enough diagnostic breadcrumbs.

TobiHartmann · 2023-08-17T11:14:12Z

compiler/startup/StartupOutput.java does the same and should then probably be improved as well. I think we can simply assert that the output contains "Out of space in CodeCache for adapters" in this case.

shipilev · 2023-08-17T15:09:50Z

Ah, I misread the intent of the fix, I think. I agree we should just check the output contains Out of space in CodeCache for adapters, and ignore the exit code.

shipilev · 2023-08-17T15:11:16Z

Or better: accept exit code 0; otherwise check the output contains the failing message. This would not fail the test if it does not reach the code cache exhaustion for some reason.

…lCountTest.java fails with java.lang.VirtualMachineError

yukikimmura · 2023-08-18T02:23:09Z

Hello everyone,

Thank you for the review and the comments.
I modified the test code.
Could you please review the fix?

Thanks,
Kimura Yukihiro

…lCountTest.java fails with java.lang.VirtualMachineError

yukikimmura · 2023-08-18T10:23:35Z

I fixed the code again, because the message is printed to stderr in the case of JBS.
The message is output to stdout if VM has not initialized,
but this test always throws VirtualMachineError and message is printed to stderr, if adapters could not be allocated.

if (!is_init_completed()) {
  // Don't throw exceptions during VM initialization because java.lang.* classes
  // might not have been initialized, causing problems when constructing the
  // Java exception object.
  vm_exit_during_initialization("Out of space in CodeCache for adapters");
} else {
  THROW_MSG_NULL(vmSymbols::java_lang_VirtualMachineError(), "Out of space in CodeCache for adapters");
}

TobiHartmann · 2023-08-18T10:29:07Z

test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java

+        if (oa.getExitValue() != 0) {
+            // Ignore adapter creation failures
+            if (!oa.getStderr().contains("Out of space in CodeCache for adapters")) {
+                throw new Exception("VM finished with exit code " + oa.getExitValue());


Please use RuntimeException like the code below does. I think you could also merge the two ifs.

Hello Tobias,

Thank you for pointing it out.
I have modified some points you had mentioned.

Thanks,
Kimura Yukihiro

…lCountTest.java fails with java.lang.VirtualMachineError

TobiHartmann

Thanks, the latest version looks good to me!

openjdk · 2023-08-18T14:17:55Z

@yukikimmura This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError

Reviewed-by: shade, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

9f4a9fe: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
7c169a4: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD()
2eae13c: 8214248: (fs) Files:mismatch spec clarifications
ce1ded1: 8314749: Remove unimplemented _Copy_conjoint_oops_atomic
32bf468: 8314274: G1: Fix -Wconversion warnings around G1CardSetArray::_data
eb06572: 8313408: Use SVG for BoxLayout example
20e9478: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
69d900d: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
f39fc0a: 8314738: Remove all occurrences of and support for @Revised
6b9df03: 8311240: Eliminate usage of testcases.jar from TestMetaSpaceLog.java
... and 44 more: https://git.openjdk.org/jdk/compare/ed585d16b9069a678bb8633239ca87f64c956fdd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

yukikimmura · 2023-08-20T07:41:46Z

Let me ask you if I can type "integrate".
Should I wait until some other work is done?

Thanks,
Kimura Yukihiro

shipilev · 2023-08-21T09:35:43Z

test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java

-        oa.shouldHaveExitValue(0);
+        // Ignore adapter creation failures
+        if (oa.getExitValue() != 0 && !oa.getStderr().contains("Out of space in CodeCache for adapters")) {
+            throw new RuntimeException("VM finished with exit code " + oa.getExitValue());


We also need oa.reportDiagnosticSummary(); in this block. Otherwise we lose debugging information when throwing this exception.

Thank you for your advice.
I have modified the point you had mentioned.

Thanks,
Kimura Yukihiro

…lCountTest.java fails with java.lang.VirtualMachineError

shipilev

Looks fine.

shipilev · 2023-08-22T10:47:10Z

@yukikimmura, you can /integrate now.

yukikimmura · 2023-08-22T23:17:34Z

/integrate

openjdk · 2023-08-22T23:19:28Z

@yukikimmura
Your change (at version 9a40972) is now ready to be sponsored by a Committer.

shipilev · 2023-08-23T06:02:42Z

/sponsor

openjdk · 2023-08-23T06:04:30Z

Going to push as commit d1de3d0.
Since your change was applied there have been 57 commits pushed to the master branch:

a0d0f21: 8314752: Use google test string comparison macros
7e843c2: 8284772: GHA: Use GCC Major Version Dependencies Only
ba6cdbe: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
9f4a9fe: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
7c169a4: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD()
2eae13c: 8214248: (fs) Files:mismatch spec clarifications
ce1ded1: 8314749: Remove unimplemented _Copy_conjoint_oops_atomic
32bf468: 8314274: G1: Fix -Wconversion warnings around G1CardSetArray::_data
eb06572: 8313408: Use SVG for BoxLayout example
20e9478: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
... and 47 more: https://git.openjdk.org/jdk/compare/ed585d16b9069a678bb8633239ca87f64c956fdd...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-08-23T06:04:41Z

@shipilev @yukikimmura Pushed as commit d1de3d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFul…

01082f5

…lCountTest.java fails with java.lang.VirtualMachineError

openjdk bot added the rfr Pull request is ready for review label Aug 17, 2023

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 17, 2023

shipilev suggested changes Aug 17, 2023

View reviewed changes

8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFul…

24874b1

…lCountTest.java fails with java.lang.VirtualMachineError

8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFul…

6b958a9

…lCountTest.java fails with java.lang.VirtualMachineError

TobiHartmann reviewed Aug 18, 2023

View reviewed changes

8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFul…

2e63136

…lCountTest.java fails with java.lang.VirtualMachineError

TobiHartmann approved these changes Aug 18, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 18, 2023

shipilev suggested changes Aug 21, 2023

View reviewed changes

8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFul…

9a40972

…lCountTest.java fails with java.lang.VirtualMachineError

shipilev approved these changes Aug 21, 2023

View reviewed changes

TobiHartmann approved these changes Aug 21, 2023

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 22, 2023

openjdk bot added the integrated Pull request has been integrated label Aug 23, 2023

openjdk bot closed this Aug 23, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError #15329

8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError #15329

yukikimmura commented Aug 17, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Aug 17, 2023

openjdk bot commented Aug 17, 2023

mlbridge bot commented Aug 17, 2023 •

edited

Loading

shipilev left a comment

TobiHartmann commented Aug 17, 2023

shipilev commented Aug 17, 2023

shipilev commented Aug 17, 2023

yukikimmura commented Aug 18, 2023

yukikimmura commented Aug 18, 2023

TobiHartmann Aug 18, 2023

yukikimmura Aug 18, 2023

TobiHartmann left a comment

openjdk bot commented Aug 18, 2023 •

edited

Loading

yukikimmura commented Aug 20, 2023

shipilev Aug 21, 2023

yukikimmura Aug 21, 2023

shipilev left a comment

shipilev commented Aug 22, 2023

yukikimmura commented Aug 22, 2023

openjdk bot commented Aug 22, 2023

shipilev commented Aug 23, 2023

openjdk bot commented Aug 23, 2023

openjdk bot commented Aug 23, 2023

8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError #15329

8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError #15329

Conversation

yukikimmura commented Aug 17, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Aug 17, 2023

openjdk bot commented Aug 17, 2023

mlbridge bot commented Aug 17, 2023 • edited Loading

Webrevs

shipilev left a comment

Choose a reason for hiding this comment

TobiHartmann commented Aug 17, 2023

shipilev commented Aug 17, 2023

shipilev commented Aug 17, 2023

yukikimmura commented Aug 18, 2023

yukikimmura commented Aug 18, 2023

TobiHartmann Aug 18, 2023

Choose a reason for hiding this comment

yukikimmura Aug 18, 2023

Choose a reason for hiding this comment

TobiHartmann left a comment

Choose a reason for hiding this comment

openjdk bot commented Aug 18, 2023 • edited Loading

yukikimmura commented Aug 20, 2023

shipilev Aug 21, 2023

Choose a reason for hiding this comment

yukikimmura Aug 21, 2023

Choose a reason for hiding this comment

shipilev left a comment

Choose a reason for hiding this comment

shipilev commented Aug 22, 2023

yukikimmura commented Aug 22, 2023

openjdk bot commented Aug 22, 2023

shipilev commented Aug 23, 2023

openjdk bot commented Aug 23, 2023

openjdk bot commented Aug 23, 2023

yukikimmura commented Aug 17, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Aug 17, 2023 •

edited

Loading

openjdk bot commented Aug 18, 2023 •

edited

Loading