-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed #15330
Conversation
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
@plummercj The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself is fine.
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up. This is a trivial fix.
Thank you for the reviews Dan and Serguei! /integrate |
Going to push as commit fbe28ee.
Your commit was automatically rebased without conflicts. |
@plummercj Pushed as commit fbe28ee. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
JDK-8250630 introduced the following change:
After this change it is no longer possible for the RETURN_ERROR block to ever be executed because listenAddr can not ever still be NULL. The entire block should be removed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15330/head:pull/15330
$ git checkout pull/15330
Update a local copy of the PR:
$ git checkout pull/15330
$ git pull https://git.openjdk.org/jdk.git pull/15330/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15330
View PR using the GUI difftool:
$ git pr show -t 15330
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15330.diff
Webrev
Link to Webrev Comment