Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed #15330

Closed
wants to merge 2 commits into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Aug 17, 2023

JDK-8250630 introduced the following change:

     if (listenAddr == NULL) {
+        // No address of preferred addres family found, grab the fist one.
+        listenAddr = &(addrInfo[0]);
+    }
+
+    if (listenAddr == NULL) {
         dbgsysFreeAddrInfo(addrInfo);
         RETURN_ERROR(JDWPTRANSPORT_ERROR_INTERNAL, "listen failed: wrong address");
     }

After this change it is no longer possible for the RETURN_ERROR block to ever be executed because listenAddr can not ever still be NULL. The entire block should be removed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15330/head:pull/15330
$ git checkout pull/15330

Update a local copy of the PR:
$ git checkout pull/15330
$ git pull https://git.openjdk.org/jdk.git pull/15330/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15330

View PR using the GUI difftool:
$ git pr show -t 15330

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15330.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8314481 8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed Aug 17, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 17, 2023
@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 17, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2023

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is fine.

@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed

Reviewed-by: dcubed, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 62ca001: 8313357: Revisit requiring SA tests on OSX to either run as root or use sudo
  • 388dcff: 8282712: VMConnection.open() does not detect if VM failed to be created, resulting in NPE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 17, 2023
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@plummercj
Copy link
Contributor Author

Thank you for the reviews Dan and Serguei!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

Going to push as commit fbe28ee.
Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2023
@openjdk openjdk bot closed this Aug 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2023
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@plummercj Pushed as commit fbe28ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants