-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8257487: Include configuration name in summary #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under impression it was printed already, but it is not! Current build only prints the configuration path in build
, which you can derive the config name from it. Printing the configuration name explicitly would be a nice touch for sure. Looks good.
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@magicus Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 60f2ba9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
According to the enhancement request:
It would be nice and convenient to include the configuration name in the configuration summary, for example ("Name" being new):
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1534/head:pull/1534
$ git checkout pull/1534