8299658: C1 compilation crashes in LinearScan::resolve_exception_edge

[TheRealMDoerr]

This is a quick fix for the C1 problem described in the JBS issue.
When we find an illegal operand (modelled by nullptr) while resolving an exception edge we can propagate this state to the phi function and skip the edge.

If somebody finds a better way to propagate the "illegal" state to the phi function, I can change or close this PR.

Please review. A nice regression test would be a good thing, but probably not easy to write.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299658: C1 compilation crashes in LinearScan::resolve_exception_edge (Bug - P3)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15348/head:pull/15348
$ git checkout pull/15348

Update a local copy of the PR:
$ git checkout pull/15348
$ git pull https://git.openjdk.org/jdk.git pull/15348/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15348

View PR using the GUI difftool:
$ git pr show -t 15348

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15348.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7f68946f)

[TobiHartmann]

That looks reasonable to me.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299658: C1 compilation crashes in LinearScan::resolve_exception_edge

Reviewed-by: thartmann, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

• 752a438: 8314684: Add overview docs to loaderConstraints.cpp
• acd9310: 8313430: [JVMCI] fatal error: Never compilable: in JVMCI shutdown
• 8a5db6b: 8237542: JMapHeapConfigTest.java doesn't work with negative jlong values
• d0cc043: 8314550: [macosx-aarch64] serviceability/sa/TestJmapCore.java fails with "sun.jvm.hotspot.debugger.UnmappedAddressException: 801000800"
• 837d2e1: 8314483: Optionally override copyright header in generated source
• 3201623: 8310454: Introduce static-libs-graal bundle
• e9ba8d5: 8314960: Add Certigna Root CA - 2
• 837cf85: 8312547: Max/Min nodes Value implementation could be improved
• 7342f5a: 8314333: Update com/sun/jdi/ProcessAttachTest.java to use ProcessTools.createTestJvm(..)
• f139f30: 8315033: Problemlist java/lang/template/StringTemplateTest.java
• ... and 64 more: https://git.openjdk.org/jdk/compare/f481477144d25bf2b5ee44f202705588bd99d4f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealLucy]

Looks reasonable.
For sure you can't continue if from_value isn't a valid operand.

[TheRealMDoerr]

Thanks for the reviews! I think it's time for verifying it in the field. Let's ship it with an EA build.
/integrate

[openjdk]

Going to push as commit cf2d33c.
Since your change was applied there have been 78 commits pushed to the master branch:

• 1664e79: 8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations
• 0901d75: 8314762: Make {@Incubating} conventional
• 12de9b0: 8314148: Fix variable scope in SunMSCAPI
• 7fbad4c: 8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes()
• 752a438: 8314684: Add overview docs to loaderConstraints.cpp
• acd9310: 8313430: [JVMCI] fatal error: Never compilable: in JVMCI shutdown
• 8a5db6b: 8237542: JMapHeapConfigTest.java doesn't work with negative jlong values
• d0cc043: 8314550: [macosx-aarch64] serviceability/sa/TestJmapCore.java fails with "sun.jvm.hotspot.debugger.UnmappedAddressException: 801000800"
• 837d2e1: 8314483: Optionally override copyright header in generated source
• 3201623: 8310454: Introduce static-libs-graal bundle
• ... and 68 more: https://git.openjdk.org/jdk/compare/f481477144d25bf2b5ee44f202705588bd99d4f4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit cf2d33c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.