8257471: fatal error: Fatal exception in JVMCI: Exception during JVMCI compiler initialization

[dougxc]

Following on from JDK-8257220, this PR converts more JVMCI configuration error handling to avoid a hard VM crash.

For example, in a JDK build that excludes Graal, instead of:

Exception during JVMCI compiler initialization
jdk.vm.ci.common.JVMCIError: Cannot use JVMCI compiler: No JVMCI compiler found
	at jdk.vm.ci.hotspot.HotSpotJVMCICompilerConfig$DummyCompilerFactory.compileMethod(jdk.internal.vm.ci/HotSpotJVMCICompilerConfig.java:60)
	at jdk.vm.ci.hotspot.HotSpotJVMCICompilerConfig$DummyCompilerFactory.compileMethod(jdk.internal.vm.ci/HotSpotJVMCICompilerConfig.java:48)
	at jdk.vm.ci.hotspot.HotSpotJVMCIRuntime.compileMethod(jdk.internal.vm.ci/HotSpotJVMCIRuntime.java:799)
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (jvmciRuntime.cpp:1102), pid=62404, tid=41731
#  fatal error: Fatal exception in JVMCI: Exception during JVMCI compiler initialization
#
# JRE version: OpenJDK Runtime Environment (16.0) (build 16-internal+0-adhoc.dnsimon.open)
# Java VM: OpenJDK 64-Bit Server VM (16-internal+0-adhoc.dnsimon.open, mixed mode, tiered, jvmci, jvmci compiler, compressed oops, g1 gc, bsd-amd64)
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/dnsimon/jdk-jdk/open/hs_err_pid62404.log
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
#
fish: 'build/macosx-x86_64-server-rele…' terminated by signal SIGABRT (Abort)

The VM now exits with:

Cannot use JVMCI compiler: No JVMCI compiler found

In both cases, the VM exits with non-zero exit code.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257471: fatal error: Fatal exception in JVMCI: Exception during JVMCI compiler initialization

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tom Rodriguez (@tkrodriguez - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1535/head:pull/1535
$ git checkout pull/1535

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (051bcf9)
• 00: Full (74b40510ff0f79e357f3ffb7068617804eac21b8)

[vnkozlov]

Good. I verified that fix works (no crash):

> java -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+UseJVMCICompiler -Xcomp -version
Cannot use JVMCI compiler: No JVMCI compiler found

compiler/jvmci tests passed locally.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257471: fatal error: Fatal exception in JVMCI: Exception during JVMCI compiler initialization

Reviewed-by: kvn, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 03f3b8e: 8210253: Clipped UI rendering with X11 pipeline and HiDPI
• ce496cb: 8257190: simplify PhaseIdealLoop constructors
• 927504e: 8256474: Migrate Mutex _owner accesses to use Atomic operations
• 00e79db: 8257511: JDK-8254082 brings regression to AbstractStringBuilder.insert(int dstOffset, CharSequence s, int start, int end)
• 015e6e5: 8257460: Further CompilerOracle cleanup
• 29d90b9: 8255968: Confusing error message for inaccessible constructor
• c5046ca: 8246739: InputStream.skipNBytes could be implemented more efficiently
• 56b15fb: 8159746: (proxy) Support for default methods
• 1433baf: 8253751: Dependencies of automatic modules are not propagated through module layers
• e3d0f27: 8257231: assert(!is_mcall || (call_returns[block->_pre_order] <= (uint) current_offset))
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/3d460bd29566b7b6cdfcc463d5dc4b1354b07258...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

/integrate

[openjdk]

@dougxc Since your change was applied there have been 27 commits pushed to the master branch:

• 3e3745c: 8256008: UL does not report anything if disk writing fails
• fb139cf: 8257467: [TESTBUG] -Wdeprecated-declarations is reported at sigset() in exesigtest.c
• 9de283b: 8257505: nsk/share/test/StressOptions stressTime is scaled in getter but not when printed
• 282cb32: 8005970: Mouse cursor is default cursor over TextArea's scrollbar
• f2a0988: 8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow
• fe5cccc: 8254631: Better support ALPN byte wire values in SunJSSE
• 541c7f7: 8257434: jpackage fails to create rpm on Fedora Linux
• 8f4fa3f: 8257232: CompileThresholdScaling fails to work on 32-bit platforms
• cfd070e: 8257537: [vector] Cleanup redundant bitwise cases on floating point vectors
• 03f3b8e: 8210253: Clipped UI rendering with X11 pipeline and HiDPI
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/3d460bd29566b7b6cdfcc463d5dc4b1354b07258...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7e37c7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.