Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314610: hotspot can't compile with the latest of gtest because of <iomanip> #15352

Closed
wants to merge 1 commit into from

Conversation

navyxliu
Copy link
Member

@navyxliu navyxliu commented Aug 18, 2023

This patch fixed a compilation error when we use the latest gtest. Because gtest has removed
from its header files(link), we should include it by ourselves, or we can't find the definition of std::setw.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314610: hotspot can't compile with the latest of gtest because of <iomanip> (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15352/head:pull/15352
$ git checkout pull/15352

Update a local copy of the PR:
$ git checkout pull/15352
$ git pull https://git.openjdk.org/jdk.git pull/15352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15352

View PR using the GUI difftool:
$ git pr show -t 15352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15352.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2023

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 18, 2023
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@navyxliu The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 18, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2023

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Aug 19, 2023

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314610: hotspot can't compile with the latest of gtest because of <iomanip>

Reviewed-by: jiefu, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 58f5826: 8311222: strace004 can fail due to unexpected stack length after JDK-8309408

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 19, 2023
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@navyxliu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 19, 2023

Going to push as commit febc34d.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 58f5826: 8311222: strace004 can fail due to unexpected stack length after JDK-8309408

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 19, 2023
@openjdk openjdk bot closed this Aug 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 19, 2023
@openjdk
Copy link

openjdk bot commented Aug 19, 2023

@navyxliu Pushed as commit febc34d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@navyxliu navyxliu deleted the JDK-8314610 branch August 19, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants