Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314157: G1: "yielded" is not initialized on some paths after JDK-8140326 #15359

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Aug 21, 2023

Hi all,

can I have reviews for this change that fixes a bug with with some variable not being initialized, leading to (minor) unnecessary work.

The use of the yielded variable is an optimization to not re-check TARSes again if there has been no yielding (safepoint) while processing. Maybe it is useful to remove it because the re-echeck for TARS isn't that expensive anyway.

Testing: tier1-3

Thanks,
Thomas

Note: this has been edited to only cover the uninitialized variables after after @albertnetymk pointed out that the original error analysis has been wrong. There is some more information in the CR about the original analysis.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314157: G1: "yielded" is not initialized on some paths after JDK-8140326 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15359/head:pull/15359
$ git checkout pull/15359

Update a local copy of the PR:
$ git checkout pull/15359
$ git pull https://git.openjdk.org/jdk.git pull/15359/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15359

View PR using the GUI difftool:
$ git pr show -t 15359

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15359.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8314157 8314157: G1: TARSes not cleared after JDK-8140326, making yielding during scrubbing inoperable Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 21, 2023
@tschatzl tschatzl marked this pull request as ready for review August 21, 2023 09:06
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 21, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2023

Webrevs

…unconditionally in G1ClearBitmapClosure already, so no issue here.
@tschatzl tschatzl changed the title 8314157: G1: TARSes not cleared after JDK-8140326, making yielding during scrubbing inoperable 8314157: G1: "yielded" is not initialized on some paths after JDK-8140326 Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314157: G1: "yielded" is not initialized on some paths after JDK-8140326

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 7e843c2: 8284772: GHA: Use GCC Major Version Dependencies Only
  • ba6cdbe: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
  • 9f4a9fe: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 7c169a4: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD()
  • 2eae13c: 8214248: (fs) Files:mismatch spec clarifications
  • ce1ded1: 8314749: Remove unimplemented _Copy_conjoint_oops_atomic
  • 32bf468: 8314274: G1: Fix -Wconversion warnings around G1CardSetArray::_data
  • eb06572: 8313408: Use SVG for BoxLayout example
  • 20e9478: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
  • 69d900d: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • ... and 12 more: https://git.openjdk.org/jdk/compare/8939d15d92982300f090bc1c51f59550529eaaf3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 21, 2023
@tschatzl
Copy link
Contributor Author

Thanks @albertnetymk @walulyai for your reviews

/integrate

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

Going to push as commit 742e319.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 1cee3b9: 8313262: C2: Sinking node may cause required cast to be dropped
  • f8203cb: 8313626: C2 crash due to unexpected exception control flow
  • 2be469f: 8314743: Use of uninitialized local in SR_initialize after JDK-8314114
  • 571c435: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds
  • d1de3d0: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
  • a0d0f21: 8314752: Use google test string comparison macros
  • 7e843c2: 8284772: GHA: Use GCC Major Version Dependencies Only
  • ba6cdbe: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
  • 9f4a9fe: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 7c169a4: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD()
  • ... and 18 more: https://git.openjdk.org/jdk/compare/8939d15d92982300f090bc1c51f59550529eaaf3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 23, 2023
@openjdk openjdk bot closed this Aug 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@tschatzl Pushed as commit 742e319.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8314157-incomplete-yield-for-reclaimed-regions branch August 23, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants