-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8314656: GHA: No need for Debian ports keyring installation after JDK-8313701 #15362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
e2fef49 to
f364f61
Compare
|
@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the cleanup.
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Thanks! Last call for reviews. I'll integrate soon otherwise. |
|
/integrate |
|
Going to push as commit 76b9011.
Your commit was automatically rebased without conflicts. |
There is no need for keyring installation after JDK-8313701. We can simplify that part to reduce the difference between different JDK releases.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15362/head:pull/15362$ git checkout pull/15362Update a local copy of the PR:
$ git checkout pull/15362$ git pull https://git.openjdk.org/jdk.git pull/15362/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15362View PR using the GUI difftool:
$ git pr show -t 15362Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15362.diff
Webrev
Link to Webrev Comment