8314746: Remove unused private put* methods from DirectByteBufferR

[turbanoff]

1. private ByteBuffer putChar(long a, char x)
2. private ByteBuffer putShort(long a, short x)
3. private ByteBuffer putInt(long a, int x)
4. private ByteBuffer putLong(long a, long x)
5. private ByteBuffer putFloat(long a, float x)
6. private ByteBuffer putDouble(long a, double x)

This methods are only called from this fragment and calls are guarded by #if[rw]

jdk/src/java.base/share/classes/java/nio/Direct-X-Buffer-bin.java.template

Lines 61 to 82 in 17a19dc

	private ByteBuffer put$Type$(long a, $type$ x) {
	#if[rw]
	try {
	$memtype$ y = $toBits$(x);
	SCOPED_MEMORY_ACCESS.put$Memtype$Unaligned(session(), null, a, y, bigEndian);
	} finally {
	Reference.reachabilityFence(this);
	}
	return this;
	#else[rw]
	throw new ReadOnlyBufferException();
	#end[rw]
	}
	public ByteBuffer put$Type$($type$ x) {
	#if[rw]
	put$Type$(ix(nextPutIndex($BYTES_PER_VALUE$)), x);
	return this;
	#else[rw]
	throw new ReadOnlyBufferException();
	#end[rw]
	}

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314746: Remove unused private put* methods from DirectByteBufferR (Enhancement - P5)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15365/head:pull/15365
$ git checkout pull/15365

Update a local copy of the PR:
$ git checkout pull/15365
$ git pull https://git.openjdk.org/jdk.git pull/15365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15365

View PR using the GUI difftool:
$ git pr show -t 15365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15365.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a412d63d)

[AlanBateman]

If it's building and the jdk_nio tests are passing then they should be. okay.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314746: Remove unused private put* methods from DirectByteBufferR

Reviewed-by: alanb, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 20e9478: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
• 69d900d: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
• f39fc0a: 8314738: Remove all occurrences of and support for @Revised
• 6b9df03: 8311240: Eliminate usage of testcases.jar from TestMetaSpaceLog.java
• 3e1b1bf: 8314688: VM build without C1 fails after JDK-8313372
• 02ef859: 8313689: C2: compiler/c2/irTests/scalarReplacement/AllocationMergesTests.java fails intermittently with -XX:-TieredCompilation
• ab86d23: 8250269: Replace ATTRIBUTE_ALIGNED with alignas
• a66b5df: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected
• 87298d2: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException
• 78f74bc: 8314672: ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all and windows-x64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

This builds and passes the NIO tests on Linux.

[turbanoff]

/integrate

[openjdk]

Going to push as commit fae3b02.
Since your change was applied there have been 28 commits pushed to the master branch:

• 096b7ff: 8314810: (fs) java/nio/file/Files/CopyInterference.java should use TestUtil::supportsLinks
• 6261020: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
• 703817d: 8314517: some tests fail in case ipv6 is disabled on the machine
• 742e319: 8314157: G1: "yielded" is not initialized on some paths after JDK-8140326
• 1cee3b9: 8313262: C2: Sinking node may cause required cast to be dropped
• f8203cb: 8313626: C2 crash due to unexpected exception control flow
• 2be469f: 8314743: Use of uninitialized local in SR_initialize after JDK-8314114
• 571c435: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds
• d1de3d0: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
• a0d0f21: 8314752: Use google test string comparison macros
• ... and 18 more: https://git.openjdk.org/jdk/compare/17a19dc06062331c954fa519a4f668664b1533c9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit fae3b02.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.