Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314672: ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all and windows-x64 #15366

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Aug 21, 2023

A trivial fix to ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all and windows-x64.

This test was previously ProblemListed on linux-all with ZGC via:

JDK-8314533 ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all with ZGC

but we have had 7 new failures in different configs since then
so the ProblemListing needs to be wider. I thought above using
generic-all, but we haven't seen an macosx-x64 failure since
mid-May 2020 and have yet to see a macosx-aarch64 failure.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314672: ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all and windows-x64 (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15366/head:pull/15366
$ git checkout pull/15366

Update a local copy of the PR:
$ git checkout pull/15366
$ git pull https://git.openjdk.org/jdk.git pull/15366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15366

View PR using the GUI difftool:
$ git pr show -t 15366

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15366.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review August 21, 2023 17:06
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314672: ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all and windows-x64

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 21, 2023
@dcubed-ojdk
Copy link
Member Author

@azvegint - Thanks for the lightning fast review!

/integrate auto

@openjdk openjdk bot added the auto label Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@dcubed-ojdk This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

Going to push as commit 78f74bc.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2023
@openjdk openjdk bot closed this Aug 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@openjdk[bot] Pushed as commit 78f74bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Aug 21, 2023

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8314672 branch August 21, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants