Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD() #15371

Closed

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Aug 21, 2023

VM.buildLongFromIntsPD() is not longer used. Remove it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD() (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15371/head:pull/15371
$ git checkout pull/15371

Update a local copy of the PR:
$ git checkout pull/15371
$ git pull https://git.openjdk.org/jdk.git pull/15371/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15371

View PR using the GUI difftool:
$ git pr show -t 15371

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15371.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8312232 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD() Aug 21, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 21, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2023

Webrevs

@@ -407,6 +407,7 @@ private static void checkVMVersion(String vmRelease) {
}

private VM(TypeDataBase db, JVMDebugger debugger, boolean isBigEndian) {
System.out.println("VM()");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it added intentionally?

@@ -953,20 +946,20 @@ public boolean isSharingEnabled() {
}

public boolean isCompressedOopsEnabled() {
if (compressedOopsEnabled == null) {
//if (compressedOopsEnabled == null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand how this changes are related to the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was working on another CR at the same time and had added debugging code. I thought I stripped it all out before doing the commit, but it looks like I didn't save the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now.

Copy link
Member

@lmesnik lmesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update copyright in the src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/StackValueCollection.java

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD()

Reviewed-by: lmesnik, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 02ef859: 8313689: C2: compiler/c2/irTests/scalarReplacement/AllocationMergesTests.java fails intermittently with -XX:-TieredCompilation
  • ab86d23: 8250269: Replace ATTRIBUTE_ALIGNED with alignas
  • a66b5df: 8314618: RISC-V: -XX:MaxVectorSize does not work as expected
  • 87298d2: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 21, 2023
@kevinjwalls
Copy link
Contributor

StackValueCollection.java looks like it mirrors src/hotspot/share/runtime/stackValueCollection.cpp
which has long_at which is used rarely, but at least once in all of hotspot. But not an obvious need for it in SA.

Looks like the SA floatAt is also unused.
So if we don't see a need to maintain a full mirror of stackValueCollection.cpp then it could be trimmed more. 8-)

@plummercj
Copy link
Contributor Author

Looks like the SA floatAt is also unused.
So if we don't see a need to maintain a full mirror of stackValueCollection.cpp then it could be trimmed more. 8-)

I think I'll leave it in. The main goal here was to prune some code that was known to be broken...and also unused.

@plummercj
Copy link
Contributor Author

Thanks for the reviews Leonid and Kevin!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 22, 2023

Going to push as commit 7c169a4.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 2eae13c: 8214248: (fs) Files:mismatch spec clarifications
  • ce1ded1: 8314749: Remove unimplemented _Copy_conjoint_oops_atomic
  • 32bf468: 8314274: G1: Fix -Wconversion warnings around G1CardSetArray::_data
  • eb06572: 8313408: Use SVG for BoxLayout example
  • 20e9478: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
  • 69d900d: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f39fc0a: 8314738: Remove all occurrences of and support for @Revised
  • 6b9df03: 8311240: Eliminate usage of testcases.jar from TestMetaSpaceLog.java
  • 3e1b1bf: 8314688: VM build without C1 fails after JDK-8313372
  • 02ef859: 8313689: C2: compiler/c2/irTests/scalarReplacement/AllocationMergesTests.java fails intermittently with -XX:-TieredCompilation
  • ... and 3 more: https://git.openjdk.org/jdk/compare/78f74bc8ff1e673991d91a55ef70880d9fb3f6b5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 22, 2023
@openjdk openjdk bot closed this Aug 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2023
@openjdk
Copy link

openjdk bot commented Aug 22, 2023

@plummercj Pushed as commit 7c169a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants