8314319: LogCompilation doesn't reset lateInlining when it encounters a failure.

[navyxliu]

This patch fixed a bug in LogCompilation. A compilation may encounter a failure after it processes
'<late_inline>' tag. Sometimes, C2 compiler would retry after tweaking options. In this case, it would retry it
without subsume_load. If we don't reset lateInlining, we may have trouble in the retry run.

We also develop a unittest to verify that. A strip jit.xml is placed in test/resources/ directory.

It's worth noting that 'mvn test' reports the 2 tests passed even without this patch. We can see the stacktrace
of exceptions. This isn't an accident. There are 2 reasons:

1. LogParser::parse swallows any throwable in its exception handler.
2. surefire runs in parallel and can't capture the failure.

I am not sure they are by design. I manage to fix those 2 problems, but fixing them is beyond the scope of this
patch. I would like to hear reviewer's feedbacks first.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314319: LogCompilation doesn't reset lateInlining when it encounters a failure. (Bug - P4)

Reviewers

• Eric Caspole (@ericcaspole - Committer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15375/head:pull/15375
$ git checkout pull/15375

Update a local copy of the PR:
$ git checkout pull/15375
$ git pull https://git.openjdk.org/jdk.git pull/15375/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15375

View PR using the GUI difftool:
$ git pr show -t 15375

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15375.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@navyxliu The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fbad34c1)

[navyxliu]

Hi,
Can I get reviewed for this change?
thanks,
--lx

[ericcaspole]

Looks good, thanks for figuring this out.

[vnkozlov]

Looks good.
I ran tier1 testing to make sure it passed our source code validation (for your new test). It passed.

[openjdk]

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314319: LogCompilation doesn't reset lateInlining when it encounters a failure.

Reviewed-by: ecaspole, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 130 new commits pushed to the master branch:

• 7754ac0: 8314925: ChoiceFormat does not specify IllegalArgumentExceptions
• 2264667: 8315422: getSoTimeout() would be in try block in SSLSocketImpl
• d5973bd: 6333341: [BI] Doc: java.text.BreakIterator class specification is unclear
• 63f561f: 8306882: (fs) Path.toRealPath(LinkOption.NOFOLLOW_LINKS) fails when "../../" follows a link
• 2436fb0: 8312306: Add more Reference.reachabilityFence() calls to the security classes using Cleaner
• 351c31e: 8315378: [BACKOUT] runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)"
• c12ca88: 8312521: Unused field LocaleProviderAdapter#defaultLocaleProviderAdapter could be removed
• b38bcae: 8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
• c8acab1: 8315413: Remove special filtering of Continuation.yield0 in StackWalker
• ea5aa61: 8315383: jlink SystemModulesPlugin incorrectly parses the options
• ... and 120 more: https://git.openjdk.org/jdk/compare/87298d2ade41c689d3140981a123b0e9130fc651...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[navyxliu]

thank you for reviewing this!

[navyxliu]

/integrate

[openjdk]

Going to push as commit e9e0c56.
Since your change was applied there have been 140 commits pushed to the master branch:

• 56b8db1: 8258970: Disabled JPasswordField foreground color is wrong with GTK LAF
• 0d4cadb: 8315195: RISC-V: Update hwprobe query for new extensions
• b4f7069: 8315446: G1: Remove unused G1AllocRegion::attempt_allocation
• cf02cf3: 8315098: Improve URLEncodeDecode microbenchmark
• c32e340: 8315321: [aix] os::attempt_reserve_memory_at must map at the requested address or fail
• 42f5b9e: 8315436: HttpsServer does not send TLS alerts
• 033f311: 8315069: Relativize extended_sp in interpreter frames
• c2e01eb: 8313983: jmod create --target-platform should replace existing ModuleTarget attribute
• 81b5d22: 8315459: Print G1 reserved and committed sizes as separate items in VM.info and hs_err
• 764f65c: 8315278: Patch 'print-targets' target to print targets separated by new line
• ... and 130 more: https://git.openjdk.org/jdk/compare/87298d2ade41c689d3140981a123b0e9130fc651...master

Your commit was automatically rebased without conflicts.

[openjdk]

@navyxliu Pushed as commit e9e0c56.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.