8314819: [JVMCI] HotSpotJVMCIRuntime.lookupType throws unexpected ClassNotFoundException

[dougxc]

This PR restores the expected behavior prior to JDK-8313421 whereby HotSpotJVMCIRuntime.lookupType throws NoClassDefFoundError instead of ClassNotFoundException.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314819: [JVMCI] HotSpotJVMCIRuntime.lookupType throws unexpected ClassNotFoundException (Bug - P3)

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer) ⚠️ Review applies to c62ba346
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15393/head:pull/15393
$ git checkout pull/15393

Update a local copy of the PR:
$ git checkout pull/15393
$ git pull https://git.openjdk.org/jdk.git pull/15393/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15393

View PR using the GUI difftool:
$ git pr show -t 15393

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15393.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (adf985d4)
• 00: Full (c62ba346)

[tkrodriguez]

Looks good.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314819: [JVMCI] HotSpotJVMCIRuntime.lookupType throws unexpected ClassNotFoundException

Reviewed-by: never, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

• 1cee3b9: 8313262: C2: Sinking node may cause required cast to be dropped
• f8203cb: 8313626: C2 crash due to unexpected exception control flow
• 2be469f: 8314743: Use of uninitialized local in SR_initialize after JDK-8314114
• 571c435: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds
• d1de3d0: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
• a0d0f21: 8314752: Use google test string comparison macros
• 7e843c2: 8284772: GHA: Use GCC Major Version Dependencies Only
• ba6cdbe: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
• 9f4a9fe: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
• 7c169a4: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD()
• ... and 62 more: https://git.openjdk.org/jdk/compare/b32d6411c406608ba5f7d60bfb8d935adb876564...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good to me.

[TobiHartmann]

Just wondering, should there be a regression test?

[dougxc]

Just wondering, should there be a regression test?

Yes. The existing tests for CompilerToVM.lookupType needed to be adjusted and I expanded them to also test HotSpotJVMCIRuntime.lookupType`: adf985d

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit 75e19e0.
Since your change was applied there have been 89 commits pushed to the master branch:

• c418933: 8313530: VM build without C2 fails after JDK-8312579
• de0e46c: 8303815: Improve Metaspace test speed
• 3699666: 8313319: [linux] mmap should use MAP_FIXED_NOREPLACE if available
• 3285a1e: 8314555: Build with mawk fails on Windows
• 4a50e87: 8303852: current_stack_region() gets called twice unnecessarily
• c077be4: 8314694: Separate checked_cast from globalDefinitions.hpp
• 68815d5: 8314734: Remove unused field TypeVariableImpl.EMPTY_ANNOTATION_ARRAY
• 57a322d: 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters
• 38a9edf: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
• 2c60cad: 8280743: HSDB "Monitor Cache Dump" command might throw NPE
• ... and 79 more: https://git.openjdk.org/jdk/compare/b32d6411c406608ba5f7d60bfb8d935adb876564...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 75e19e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.