Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314333: Update com/sun/jdi/ProcessAttachTest.java to use ProcessTools.createTestJvm(..) #15398

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Aug 23, 2023

Test updated to run debugee VM with correct options.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314333: Update com/sun/jdi/ProcessAttachTest.java to use ProcessTools.createTestJvm(..) (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15398/head:pull/15398
$ git checkout pull/15398

Update a local copy of the PR:
$ git checkout pull/15398
$ git pull https://git.openjdk.org/jdk.git pull/15398/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15398

View PR using the GUI difftool:
$ git pr show -t 15398

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15398.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2023

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@lmesnik The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 23, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2023

Webrevs

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Make sure you test with the Virtual thread factory since that adds additional argument complications.

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314333: Update com/sun/jdi/ProcessAttachTest.java to use ProcessTools.createTestJvm(..)

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

  • ba6cdbe: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
  • 9f4a9fe: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 7c169a4: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD()
  • 2eae13c: 8214248: (fs) Files:mismatch spec clarifications
  • ce1ded1: 8314749: Remove unimplemented _Copy_conjoint_oops_atomic
  • 32bf468: 8314274: G1: Fix -Wconversion warnings around G1CardSetArray::_data
  • eb06572: 8313408: Use SVG for BoxLayout example
  • 20e9478: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
  • 69d900d: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f39fc0a: 8314738: Remove all occurrences of and support for @Revised
  • ... and 72 more: https://git.openjdk.org/jdk/compare/f66c73d34b1e02681f46eb3cd78126c05014f845...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 23, 2023
@lmesnik
Copy link
Member Author

lmesnik commented Aug 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit 7342f5a.
Since your change was applied there have been 119 commits pushed to the master branch:

  • f139f30: 8315033: Problemlist java/lang/template/StringTemplateTest.java
  • f2383b3: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • dcd6e75: 8314990: Generational ZGC: Strong OopStorage stats reported as weak roots
  • 002b594: 8312749: Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • d024059: 8314951: VM build without C2 still fails after JDK-8313530
  • 2624324: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent
  • 8e4240c: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • d9fc6b6: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • acaab6f: 8306040: HttpResponseInputStream.available() returns 1 on empty stream
  • 76b9011: 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701
  • ... and 109 more: https://git.openjdk.org/jdk/compare/f66c73d34b1e02681f46eb3cd78126c05014f845...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@lmesnik Pushed as commit 7342f5a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants