Skip to content

8310454: Introduce static-libs-graal bundle#15406

Closed
erikj79 wants to merge 1 commit intoopenjdk:masterfrom
erikj79:JDK-8310454-static-libs-graal-bundles
Closed

8310454: Introduce static-libs-graal bundle#15406
erikj79 wants to merge 1 commit intoopenjdk:masterfrom
erikj79:JDK-8310454-static-libs-graal-bundles

Conversation

@erikj79
Copy link
Member

@erikj79 erikj79 commented Aug 23, 2023

JDK-8307858 added libjvm.a to the set of static-libs in the static-libs image and subsequently the static-libs bundle. The main user of the existing static-image was the graal build, which doesn't need libjvm. Since libjvm is considerably bigger than all the other libraries, a static-libs-graal-image was introduced to cover the graal build usecase. There was no corresponding bundles target added however, so for graal builds depending on stored/published bundles, there is no way of skipping out of libjvm.

To fix this, this patch introduces a new make target: static-libs-graal-bundles.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310454: Introduce static-libs-graal bundle (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15406/head:pull/15406
$ git checkout pull/15406

Update a local copy of the PR:
$ git checkout pull/15406
$ git pull https://git.openjdk.org/jdk.git pull/15406/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15406

View PR using the GUI difftool:
$ git pr show -t 15406

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15406.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2023

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8310454 8310454: Introduce static-libs-graal bundle Aug 23, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 23, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2023

Webrevs

@jianglizhou
Copy link
Contributor

Hi @erikj79 This looks good to me from static-libs point of view. Thanks for tying the loose ends introduced by JDK-8307858.

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310454: Introduce static-libs-graal bundle

Reviewed-by: jiangli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • d9fc6b6: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • acaab6f: 8306040: HttpResponseInputStream.available() returns 1 on empty stream
  • 76b9011: 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701
  • e36620d: 8314554: Debian/Ubuntu should not link OpenJDK with --as-needed link option
  • 97b94cb: 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case
  • 75e19e0: 8314819: [JVMCI] HotSpotJVMCIRuntime.lookupType throws unexpected ClassNotFoundException
  • c418933: 8313530: VM build without C2 fails after JDK-8312579
  • de0e46c: 8303815: Improve Metaspace test speed
  • 3699666: 8313319: [linux] mmap should use MAP_FIXED_NOREPLACE if available
  • 3285a1e: 8314555: Build with mawk fails on Windows
  • ... and 2 more: https://git.openjdk.org/jdk/compare/68815d54c199d39b14034c926777b492fa453a22...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 24, 2023
@erikj79
Copy link
Member Author

erikj79 commented Aug 25, 2023

Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit 3201623.
Since your change was applied there have been 22 commits pushed to the master branch:

  • e9ba8d5: 8314960: Add Certigna Root CA - 2
  • 837cf85: 8312547: Max/Min nodes Value implementation could be improved
  • 7342f5a: 8314333: Update com/sun/jdi/ProcessAttachTest.java to use ProcessTools.createTestJvm(..)
  • f139f30: 8315033: Problemlist java/lang/template/StringTemplateTest.java
  • f2383b3: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • dcd6e75: 8314990: Generational ZGC: Strong OopStorage stats reported as weak roots
  • 002b594: 8312749: Generational ZGC: Tests crash with assert(index == 0 || is_power_of_2(index))
  • d024059: 8314951: VM build without C2 still fails after JDK-8313530
  • 2624324: 8219567: Name of first parameter of RandomAccessFile(String,String) is inconsistent
  • 8e4240c: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • ... and 12 more: https://git.openjdk.org/jdk/compare/68815d54c199d39b14034c926777b492fa453a22...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@erikj79 Pushed as commit 3201623.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants