8310454: Introduce static-libs-graal bundle#15406
8310454: Introduce static-libs-graal bundle#15406erikj79 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back erikj! A progress list of the required criteria for merging this PR into |
|
Hi @erikj79 This looks good to me from static-libs point of view. Thanks for tying the loose ends introduced by JDK-8307858. |
|
@erikj79 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Thanks for the review! /integrate |
|
Going to push as commit 3201623.
Your commit was automatically rebased without conflicts. |
JDK-8307858 added libjvm.a to the set of static-libs in the static-libs image and subsequently the static-libs bundle. The main user of the existing static-image was the graal build, which doesn't need libjvm. Since libjvm is considerably bigger than all the other libraries, a static-libs-graal-image was introduced to cover the graal build usecase. There was no corresponding bundles target added however, so for graal builds depending on stored/published bundles, there is no way of skipping out of libjvm.
To fix this, this patch introduces a new make target:
static-libs-graal-bundles.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15406/head:pull/15406$ git checkout pull/15406Update a local copy of the PR:
$ git checkout pull/15406$ git pull https://git.openjdk.org/jdk.git pull/15406/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15406View PR using the GUI difftool:
$ git pr show -t 15406Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15406.diff
Webrev
Link to Webrev Comment