8297777: Convert jdk.jlink StringSharingPlugin to use Class File API

[xqoasis]

Migrate jdk.jlink StringSharingPlugin to use new classfile library

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297777: Convert jdk.jlink StringSharingPlugin to use Class File API (Sub-task - P4)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15408/head:pull/15408
$ git checkout pull/15408

Update a local copy of the PR:
$ git checkout pull/15408
$ git pull https://git.openjdk.org/jdk.git pull/15408/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15408

View PR using the GUI difftool:
$ git pr show -t 15408

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15408.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xqoasis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xqoasis The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[asotona]

It looks good, thanks.

[mlbridge]

Webrevs

• 00: Full (d4d4f181)

[openjdk]

@xqoasis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297777: Convert jdk.jlink StringSharingPlugin to use Class File API

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

• e22762c: 8314932: G1: Fix -Wconversion warnings for simple cases inside g1 folder
• 762b652: 8314573: G1: Heap resizing at Remark does not take existing eden regions into account
• a4e97aa: 8314753: Remove support for @beaninfo, @todo, @since.unbundled, and @note
• 5cc64cc: 8309463: IGV: Dynamic graph layout algorithm
• 1d02507: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table"
• 93188bd: 8314569: (fs) Improve normalization of UnixPath for input with trailing slashes
• 8b8182d: 8315087: G1: Use uint for G1 flags indicating percentage
• 3dc266c: 8315070: RISC-V: Clean up platform dependent inline headers
• 25f5df2: 8315073: Zero build on macOS fails after JDK-8303852
• a03954e: 8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests
• ... and 45 more: https://git.openjdk.org/jdk/compare/4a50e87592d76cf1ee315f47b4da1e1156cff7cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@asotona) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[xqoasis]

/integrate

[openjdk]

@xqoasis
Your change (at version d4d4f18) is now ready to be sponsored by a Committer.

[asotona]

/sponsor

[openjdk]

Going to push as commit e29f0c2.
Since your change was applied there have been 64 commits pushed to the master branch:

• bf63945: 8298992: runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)"
• cb3f968: 8314651: G1: Fix -Wconversion warnings in static fields of HeapRegion
• 876a725: 8315206: RISC-V: hwprobe query is_set return wrong value
• ed1ea5f: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
• f3aeb02: 8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children
• 1e7e2bc: 8315214: Do not run sun/tools/jhsdb tests concurrently
• ce2a7ea: 8314056: Remove runtime platform check from frem/drem
• 1c598c2: 8312428: PKCS11 tests fail with NSS 3.91
• b2728cb: 8189685: need PerfMemory class update and a volatile_static_field support in VMStructs
• e22762c: 8314932: G1: Fix -Wconversion warnings for simple cases inside g1 folder
• ... and 54 more: https://git.openjdk.org/jdk/compare/4a50e87592d76cf1ee315f47b4da1e1156cff7cf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona @xqoasis Pushed as commit e29f0c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.